Bug 181940

Not reproducible here. Which editor tool is affected ?

Gilles Caulier

I can confirm it, I only tested "sharpen" but there the issue is already noticeable.

Andi

SVN commit 916862 by cgilles:

digiKam from trunk : force to record EditorTool preview mode settings when tool is closed.
BUG: 181940


 M  +2 -0      imageplugins/adjustcurves/adjustcurvestool.cpp  
 M  +2 -0      imageplugins/adjustlevels/adjustlevelstool.cpp  
 M  +1 -0      imageplugins/blurfx/blurfxtool.cpp  
 M  +2 -0      imageplugins/border/bordertool.cpp  
 M  +3 -1      imageplugins/channelmixer/channelmixertool.cpp  
 M  +1 -0      imageplugins/charcoal/charcoaltool.cpp  
 M  +1 -0      imageplugins/colorfx/colorfxtool.cpp  
 M  +1 -0      imageplugins/coreplugin/autocorrectiontool.cpp  
 M  +7 -6      imageplugins/coreplugin/bcgtool.cpp  
 M  +1 -0      imageplugins/coreplugin/blurtool.cpp  
 M  +1 -0      imageplugins/coreplugin/bwsepiatool.cpp  
 M  +1 -0      imageplugins/coreplugin/hsl/hsltool.cpp  
 M  +1 -0      imageplugins/coreplugin/iccprooftool.cpp  
 M  +1 -0      imageplugins/coreplugin/redeyetool.cpp  
 M  +1 -0      imageplugins/coreplugin/rgbtool.cpp  
 M  +1 -0      imageplugins/coreplugin/sharpnesseditor/sharpentool.cpp  
 M  +3 -2      imageplugins/distortionfx/distortionfxtool.cpp  
 M  +1 -0      imageplugins/emboss/embosstool.cpp  
 M  +3 -2      imageplugins/filmgrain/filmgraintool.cpp  
 M  +3 -2      imageplugins/freerotation/freerotationtool.cpp  
 M  +1 -0      imageplugins/hotpixels/hotpixelstool.cpp  
 M  +1 -0      imageplugins/infrared/infraredtool.cpp  
 M  +4 -4      imageplugins/inpainting/inpaintingtool.cpp  
 M  +2 -0      imageplugins/lenscorrection/autocorrection/autocorrectiontool.cpp  
 M  +1 -0      imageplugins/lenscorrection/distortion/lensdistortiontool.cpp  
 M  +1 -0      imageplugins/lenscorrection/vignetting/antivignettingtool.cpp  
 M  +3 -2      imageplugins/noisereduction/noisereductiontool.cpp  
 M  +1 -0      imageplugins/oilpaint/oilpainttool.cpp  
 M  +1 -0      imageplugins/raindrop/raindroptool.cpp  
 M  +1 -0      imageplugins/restoration/restorationtool.cpp  
 M  +13 -12    imageplugins/sheartool/sheartool.cpp  
 M  +3 -2      imageplugins/texture/texturetool.cpp  
 M  +1 -0      imageplugins/whitebalance/whitebalancetool.cpp  
 M  +2 -1      libs/widgets/imageplugins/imagepanelwidget.h  
 M  +1 -1      libs/widgets/imageplugins/imagewidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=916862

Wouldn't it be even better if this setting is saved as a general value?
If I change the preview mode in "Sharpen" and start "Blur" after that, I somehow expect to have the same preview mode I had used in "Sharpen" before.

Andi

Andi,

Well for the moment, each tool as a dedicated settings saved in rc file section.

Perhaps we can factorize it when we preview widget will be redesigned in 0.11

Gilles

SVN commit 916865 by cgilles:

backport commit #916862 from trunk
CCBUG: 181940


 M  +1 -0      imageplugins/adjustcurves/adjustcurvestool.cpp  
 M  +1 -0      imageplugins/adjustlevels/adjustlevelstool.cpp  
 M  +1 -0      imageplugins/antivignetting/antivignettingtool.cpp  
 M  +20 -19    imageplugins/blurfx/blurfxtool.cpp  
 M  +2 -0      imageplugins/border/bordertool.cpp  
 M  +2 -0      imageplugins/channelmixer/channelmixertool.cpp  
 M  +1 -0      imageplugins/charcoal/charcoaltool.cpp  
 M  +1 -0      imageplugins/colorfx/colorfxtool.cpp  
 M  +1 -0      imageplugins/coreplugin/autocorrectiontool.cpp  
 M  +1 -0      imageplugins/coreplugin/bcgtool.cpp  
 M  +1 -0      imageplugins/coreplugin/bwsepiatool.cpp  
 M  +1 -0      imageplugins/coreplugin/hsl/hsltool.cpp  
 M  +1 -0      imageplugins/coreplugin/iccprooftool.cpp  
 M  +1 -0      imageplugins/coreplugin/redeyetool.cpp  
 M  +17 -16    imageplugins/coreplugin/rgbtool.cpp  
 M  +1 -0      imageplugins/coreplugin/sharpnesseditor/sharpentool.cpp  
 M  +1 -0      imageplugins/distortionfx/distortionfxtool.cpp  
 M  +1 -0      imageplugins/emboss/embosstool.cpp  
 M  +1 -0      imageplugins/filmgrain/filmgraintool.cpp  
 M  +1 -0      imageplugins/freerotation/freerotationtool.cpp  
 M  +1 -0      imageplugins/hotpixels/hotpixelstool.cpp  
 M  +1 -0      imageplugins/infrared/infraredtool.cpp  
 M  +1 -0      imageplugins/inpainting/inpaintingtool.cpp  
 M  +1 -0      imageplugins/lensdistortion/lensdistortiontool.cpp  
 M  +1 -0      imageplugins/noisereduction/noisereductiontool.cpp  
 M  +1 -0      imageplugins/oilpaint/oilpainttool.cpp  
 M  +3 -2      imageplugins/raindrop/raindroptool.cpp  
 M  +1 -0      imageplugins/restoration/restorationtool.cpp  
 M  +1 -0      imageplugins/sheartool/sheartool.cpp  
 M  +1 -0      imageplugins/texture/texturetool.cpp  
 M  +1 -0      imageplugins/whitebalance/whitebalancetool.cpp  
 M  +2 -1      libs/widgets/imageplugins/imagepanelwidget.h  
 M  +10 -10    libs/widgets/imageplugins/imagewidget.h  
 M  +11 -11    project/project.kdevelop  


WebSVN link: http://websvn.kde.org/?view=rev&revision=916865

Gilles, thank you for fixing so fast!

FWIW, I think that having a common setting is fine, it is probably mostly a question of taste how one likes it. (I personally favor the "mouse over" concept and uses it everywhere available)