Bug 181721

Summary: right-click does nothing if not on or around an image in the top Light Table panel
Product: [Applications] digikam Reporter: Michael Ploujnikov <ploujj>
Component: LightTable-CanvasAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: caulier.gilles
Priority: NOR    
Version: 0.10.0   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed In: 0.10.0
Sentry Crash Report:
Attachments: Context menu patch
lighttable top anel screenshot

Description Michael Ploujnikov 2009-01-24 05:11:35 UTC 
Version:           0.10.0-rc2 (rev.: 915808) (using KDE 4.1.4)
Compiler:          gcc (GCC) 4.3.0 20080428 (Red Hat 4.3.0-8) x86_64 platform
OS:                Linux
Installed from:    Fedora RPMs

Since I don't know the keyboard shortcuts my instinct is to use the right-click pop-up menu when I want to remove all images from the Light Table.
I noticed that I keep clicking on the white/blank area of this top panel instead of on the images. Maybe this happens because it's bigger while only two images are shown. Maybe this happens because I'm subconsciously afraid of clicking on the images. It would be nice if I could right click anywhere (not just on or near an image) in the top panel of the Light Table.  When I right click on the images in the top panel, I notice an unusual delay before the pop-up appears. I think this also causes me to want to right-click on the blank area - I'm hoping that it will show the pop-up menu.
Comment 1 Andi Clemens 2009-01-24 21:39:23 UTC 
The only action that would make sense when clicking into the empty space of the thumbbar would be the "clear all" action, all the others are related to the underlaying thumbnail image.

This should be possible.
Gilles, Marcel, Arnd and others,

what do you think?

Andi
Comment 2 Andi Clemens 2009-01-24 21:52:41 UTC 
Created attachment 30573 [details]
Context menu patch

This patch will handle your request, but it looks weird now, because of the cut-off sidebar pic in the context menu.

Andi
Comment 3 caulier.gilles 2009-01-24 22:09:09 UTC 
Why do you want to distinguish right click menu with thumbnail image and the rest of item content. A thumbnail item can be selected by left mouse click everywhere in item.

Also, in album icon view, there is no difference between to right click on thumbnail image and the rest of item content.

Gilles Caulier
Comment 4 Michael Ploujnikov 2009-01-24 22:33:12 UTC 
Created attachment 30574 [details]
lighttable top anel screenshot

This screenshot shows the area where I'm trying to right-click. It is marked with the red stripes.

Also, while I was doing this an idea came to mind: maybe a "clear all" button should appear in the Light Table toolbar (where the Back/Forward, Zoom, Sync, etc buttons are show).
Comment 5 caulier.gilles 2009-01-24 22:40:34 UTC 
Ok, now i understand. 

Andi, patch is fine for me.

Gilles
Comment 6 Andi Clemens 2009-01-24 22:53:17 UTC 
Gilles,

what about the sidebar? Looks weird, but there is no way to disable it.

Andi
Comment 7 caulier.gilles 2009-01-24 22:56:40 UTC 
Andi,

Use KMenu instead DPopupMenu

Gilles
Comment 8 Andi Clemens 2009-01-24 23:01:33 UTC 
Sometimes it is so easy ... :-)
Comment 9 Andi Clemens 2009-01-24 23:07:29 UTC 
SVN commit 916232 by aclemens:

Display "Clear all" action if the user clicks into an empty space in the lighttable's thumbbar.

BUG:181721

 M  +33 -20    lighttablebar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=916232
Comment 10 Andi Clemens 2009-01-24 23:25:35 UTC 
SVN commit 916236 by aclemens:

Disable "Clear all" action if no items are inserted into the thumbbar

CCBUG:181721

 M  +2 -0      lighttablebar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=916236
Comment 11 Andi Clemens 2009-01-25 00:14:58 UTC 
SVN commit 916260 by aclemens:

backport commit #916232

CCBUG:181721

 M  +86 -76    lighttablebar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=916260