| Summary: | use KDialog instead of QDialog for quick open | ||
|---|---|---|---|
| Product: | [Developer tools] kdevplatform | Reporter: | Andreas Pakulat <apaku> |
| Component: | quickopen | Assignee: | kdevelop-bugs-null |
| Status: | RESOLVED FIXED | ||
| Severity: | major | CC: | david.nolden.kde |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
|
Description
Andreas Pakulat
2009-01-24 00:56:20 UTC
What's the optical difference and/or advantage? Actually I was thinking about moving the "Ok" and "Cancel" buttons up into the search-line, because that's where the user focus is. in this case there's probably not much optical difference. However it makes sure that KDevelop fits properly into the DE of the user (think order of ok/cancel button). It allows to embed some help info in the top of the dialog without extra code from us. The layout/margins comply with KDE HIG without us doing anything for it. The actual content of the dialog is not bound to a dialog-class (as it would be plain QWidget based), making it easier to re-use it in the future. About moving the buttons: Thats a no-go, unless you make it something else than a dialog. The user is used to the standard dialog layout and users would be confused or even "scared" when this dialog is totally different. Besides the "users focus is on the lineedit" argument is pretty weak IMHO. Sure the focus is there, but if you use the quickopen dialog you don't need the ok button at all, your typing your part of the file/class and then you hit enter (or esc if you want to quit). And if we assume mouse users, then they have probably clicked somewhere in the list to select a file, so their focus is in the middle of the dialog. SVN commit 939130 by apaku: Switch Quickopen plugin to use KDialog instead of QDialog. Thanks to Dmitry Suzdalev for the patch BUG:181704 M +40 -79 quickopen.ui M +4 -3 quickopenplugin.cpp M +1 -1 quickopenplugin.h WebSVN link: http://websvn.kde.org/?view=rev&revision=939130 |