| Summary: | The artwork API in shared library has changed slightly | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Todd Zullinger <tmz+kdebugs> |
| Component: | Portability-Runtime | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, krege, rdieter |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 0.2.0 | |
| Sentry Crash Report: | |||
| Attachments: |
kipi-plugins and new libgpod
Kipi-pkugins 0.1.6 (kde3) and new libgpod |
||
Created attachment 30676 [details]
kipi-plugins and new libgpod
This patch alow to compile kipi-plugins with new libgpod. As I saw, there are still not complete art engine, and these patch does not touch those problems. Only work with new libgpod implemented.
Now one want to compile need to install gtk2 (gdk with headers) in addition to previuose requirements. Minimak libgpos version is 0.7.0. Cmake files changed to relolve it.
Dmitrij, Thanks a lots for the patch !!! Can you try to port your fixes in KDE3 branch of plugin which is not compilable with current libgpod. Code is here : http://websvn.kde.org/branches/extragear/kde3/libs/kipi-plugins/ipodexport/ Thanks in advance Gilles Caulier SVN commit 918089 by cgilles: kipi-plugins from trunk : IpodExport tool : Patch from Dmitrij S. Kryzhevich to support new libgpod API. CCBUG: 181334 CCMAIL: ruiz@kde.org CCMAIL: krege@land.ru M +12 -5 CMakeLists.txt A cmake/modules/FindGdk.cmake M +24 -17 cmake/modules/FindGpod.cmake M +2 -1 ipodexport/CMakeLists.txt M +14 -2 ipodexport/IpodExportDialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=918089 Dmitrij, KDE4 code is now patched. My request #2 for KDE3 still valid... Gilles Caulier Created attachment 30762 [details]
Kipi-pkugins 0.1.6 (kde3) and new libgpod
I'm sorry, i have not qt3/kde3 surraund so i did not completely tested it. Autotools checks for libgpod and gdk are correct, but compilation - that's a question. If anybody can test - please, do it.
Also, gdk (gtk2) minimal version set in >=2.10.0, but i do not realy know what version is minimal indeed, if you know - please, change it. libgpod virsion set in >= 0.7.0.
Upper patch level is "branches/extragear/kde3/libs" because of some testing.
Sorry for delay, haven't free time now.
Thanks Dmitrij, I will review your patch Gilles Caulier SVN commit 919107 by cgilles: Kipiplugins from KDE3 branch : patch from Dmitrij S. Kryzhevich to compile IpodExport with new LibGpod api. BUG: 181334 CCMAIL: ruiz@kde.org CCMAIL: krege@land.ru M +3 -2 README M +12 -2 configure.in.bot M +32 -2 configure.in.in M +2 -1 ipodexport/Makefile.am M +13 -2 ipodexport/ipodexportdialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=919107 |
Version: 0.2.0beta6 (using Devel) Compiler: gcc (GCC) 4.3.2 20081105 OS: Linux Installed from: Compiled sources The artwork API in libgpod was changed in svn trunk a few months back. That new API is now in the released libgpod-0.7.0. Updating kipi-plugins to work with the new API would be great. I'm not at all familiar with kipi-plugins nor am I much of a C++ hacker, so I regret that I don't have a patch to supply in this report. However, the changes weren't extreme. A patch likely won't be very invasive. We can likely offer any help if you need it on the gtkpod-devel list [gtkpod-devel (at) lists.sourceforge.net] or via IRC at #gtkpod on freenode. The API docs for libgpod-0.7.0 are available at: http://tmz.fedorapeople.org/docs/libgpod/ (and in the libgpod tarball) Also, the patch to update gtkpod to use the new API for its photo handling is at: http://gtkpod.svn.sourceforge.net/viewvc/gtkpod/gtkpod/trunk/src/display_photo.c?r1=1987&r2=1996