Bug 181235

Summary:	gwenview (KDE 4.2 RC1) insists on saving rotated images in full-screen mode
Product:	[Applications] gwenview	Reporter:	Claus Wilke <wilke>
Component:	general	Assignee:	Gwenview Bugs <gwenview-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	benni
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Claus Wilke 2009-01-18 21:24:50 UTC

Version: 2.2.0 (using 4.1.96 (KDE 4.1.96 (KDE 4.2 RC1)) "release 76.2", KDE:KDE4:Factory:Desktop / openSUSE_11.1)
Compiler: gcc
OS: Linux (i686) release 2.6.27.7-9-default

When I open Gwenview in a folder with a couple of images (3 seems to be sufficient), display an image in full-screen mode, and then rotate it left or right (ctrl-L or ctrl-R), Gwenview forces me to save the image. It displays a message saying "You have modified many images. To avoid memory problems, you should save your changes", with the only action available to me being "Save All". The message will not go away until I press "Save All".

There are multiple problems with this message:

1. I should never be forced to save the image. At a minimum, I'd expect to have "save" and "ignore".

2. It is not true that I have modified many images, I have rotated only a single one. Certainly that is not going to lead to memory problems on any reasonably recent machine.

3. I thought that Gwenview is an image viewer, not an image editor. It's nice to have the option to rotate an image and then save it, but the default should be that rotation is treated the same as zoom, i.e., it's just a different way of looking at the image, but it's not something that modifies the image.

4. The old Gwenview (KDE 3.x) at least allowed me to select "never ask this question again" when it asked about saving rotated images. The new Gwenview doesn't have this option anymore.

I think the best way to solve this issue, besides offering an "ignore" option as indicated in my point 1, would be to have a check in the general settings where one can select "never store rotated images" (or more generally, "never store image modifications"). With this setting checked, if I rotated an image, then proceeded to view another image, and then went back to the first image, I'd see the original, unrotated image again.

Comment 1 Aurelien Gateau 2009-01-19 11:20:46 UTC

> 1. I should never be forced to save the image.

You are not forced to save. The warning bar does not prevent you from continuing to browse (and rotate) more images.

> 2. It is not true that I have modified many images, I have rotated only a
single one.

The memory algorithm can probably be improved. It is quite conservative for now. There is a hidden setting which let you can alter the minimum percentage of memory used by Gwenview before it warns you. Right now it is set to 50%.

Edit $HOME/.kde4/share/config/gwenviewrc, locate the [General] section and add "PercentageOfMemoryUsageWarning=0.8" to change the percentage to 80%.

> 3. I thought that Gwenview is an image viewer, not an image editor.

I consider Gwenview as an image viewer with simple editing features.

I think what should be done is show a close button (X) to the right of the warning bar if you don't want to be bothered by it. I can see how it can be annoying in fullscreen mode.

Comment 2 Claus Wilke 2009-01-19 20:06:17 UTC

>You are not forced to save. The warning bar does not prevent you from
>continuing to browse (and rotate) more images.

Yes, I should have been more precise: I have to save if I want to get rid of the warning bar. A close button would help, but I think it should be combined with the option to disable the warning permanently. Otherwise, I would constantly have to click on the close button to get rid of the warning, which would get old pretty soon.

> The memory algorithm can probably be improved. It is quite conservative for
> now. There is a hidden setting which let you can alter the minimum percentage
> of memory used by Gwenview before it warns you. Right now it is set to 50%.
Ok, this I don't understand. 50% of what? On my machine, with 4G of RAM, if I load a single image and rotate it I get the warning bar. At this point, Gwenview uses maybe 1% of my total RAM. Setting the hidden parameter to 80% doesn't make any difference. Gwenview still warns after loading and rotating a single image.

Comment 3 Aurelien Gateau 2009-01-19 23:20:54 UTC

> Ok, this I don't understand. 50% of what? On my machine, with 4G of RAM, if I
> load a single image and rotate it I get the warning bar.

This is 50% of the physical memory. Which means something is wrong with the way Gwenview detects the amount of physical memory available on your machine. On Linux, Gwenview uses the content of /proc/meminfo. Can you post the content of this file?

Comment 4 Claus Wilke 2009-01-20 00:06:54 UTC

Contents of /proc/meminfo:

> cat /proc/meminfo                                                                                                                      
MemTotal:      3621456 kB                                                                                                                                  
MemFree:       2049352 kB                                                                                                                                  
Buffers:         42852 kB                                                                                                                                  
Cached:         593664 kB                                                                                                                                  
SwapCached:         20 kB                                                                                                                                  
Active:         879136 kB
Inactive:       351496 kB
HighTotal:     2742636 kB
HighFree:      1541776 kB
LowTotal:       878820 kB
LowFree:        507576 kB
SwapTotal:     3911776 kB
SwapFree:      3911756 kB
Dirty:            1120 kB
Writeback:           0 kB
AnonPages:      593944 kB
Mapped:         102016 kB
Slab:           146376 kB
SReclaimable:   111712 kB
SUnreclaim:      34664 kB
PageTables:       5912 kB
NFS_Unstable:        0 kB
Bounce:              0 kB
WritebackTmp:        0 kB
CommitLimit:   5722504 kB
Committed_AS:  1026572 kB
VmallocTotal:   110584 kB
VmallocUsed:     15248 kB
VmallocChunk:    95212 kB
HugePages_Total:     0
HugePages_Free:      0
HugePages_Rsvd:      0
HugePages_Surp:      0
Hugepagesize:     4096 kB
DirectMap4k:    217088 kB
DirectMap4M:    700416 kB

Comment 5 Aurelien Gateau 2009-01-20 09:45:35 UTC

SVN commit 913943 by gateau:

Fix memory detection for systems with more than 2GB of RAM.

CCBUG:181235


 M  +4 -4      memoryutils.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=913943

Comment 6 Aurelien Gateau 2009-01-20 09:49:57 UTC

The warning should not popup that often now. Hopefully it will be a lot less annoying.

Comment 7 Aurelien Gateau 2009-01-20 11:19:17 UTC

SVN commit 913971 by gateau:

Fix memory detection for systems with more than 2GB of RAM.

CCBUG:181235



 M  +4 -4      memoryutils.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=913971

Comment 8 Benni Hill 2012-12-06 21:42:19 UTC

Is this fixed?

Comment 9 Aurelien Gateau 2012-12-07 22:25:39 UTC

Yes, this is fixed.