| Summary: | Plasma pager is a bit too big | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | Jan Mette <jan.mette> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | annma, aseigo, notmart, olaf, robinpeder |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | pager screenshot | ||
|
Description
Jan Mette
2009-01-12 11:26:10 UTC
Created attachment 30179 [details]
pager screenshot
its cut-off at the bottom
Also in trunk. Furthermore default is 1 row while it always was 2 rows. it's after revision 908477 it reomoves all the margins from the size calculation, code is simpler but doesn't seem to work very well... @Anne-Marie:
> Furthermore default is 1 row while it always was 2 rows.
really? it's 2 rows here. are you seeing this in the config dialog, or in the actual painting of the pager, or? because i'm seeing 2 rows in both situations...
@Marco: the margins are actually already added to the m_rects calculations in Pager::recalculateGeometry. the margins that that r#908477 removed were resulting in adding the margins *twice*, but only during mouse interactions, and therefore all the mouse interaction was off.
anyways.. this bug only shows itself with pager rows == 1 (here anyway).. i'll look into a fix for that.
SVN commit 910229 by aseigo: add the margins to the width/height; we do those margins, only in the mouse interaction we don't want them (re-)added BUG:180440 M +2 -2 pager.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=910229 SVN commit 910230 by aseigo: add the margins to the width/height; we do those margins, only in the mouse interaction we don't want them (re-)added CCBUG:180440 M +2 -2 pager.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=910230 Just rebuilt kdebase-workspace (rev 910273). It looks fine now, thank you :) Fixed for me as well. I had a new install and $KDEHOME and the pager as default was all 4 desktops on 1 row. This morning with Revision: 910338 it's all back to normal, default is on 2 rows and position is perfect! Unfortunately, the fix seems to have broken the resizing behaviour of the pager when it is used on the desktop (see bug 182487)... Any ideas how both bugs can be fixed at once? Reopened. See bug 182487. SVN commit 921782 by rpedersen: Handle margins correctly both when pager is on desktop and in panel This should result in correct behavior in both cases. But IMHO, this requires a better solution.. BUG: 180440 BUG: 182487 M +8 -2 pager.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=921782 SVN commit 921784 by rpedersen: backport 921782 CCBUG: 180440 CCBUG: 182487 M +8 -2 pager.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=921784 SVN commit 927574 by rpedersen: Handle margins correctly both when pager is on desktop and in panel Using Plasma::Desktop did not work, now using Plasma::Floating instead which seems to work for me. CCBUG: 180440 CCBUG: 182487 M +2 -2 pager.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=927574 |