Bug 180006

Summary: Camera GUI window title contains '&'
Product: [Applications] digikam Reporter: Will Stephenson <wstephenson>
Component: Import-Gphoto2Assignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: opensourcecat
Priority: NOR    
Version: 0.10.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Unspecified   
Latest Commit: Version Fixed In: 0.10.0
Sentry Crash Report:
Attachments: Camera gui showing & before camera name

Description Will Stephenson 2009-01-08 10:53:53 UTC
Version:            (using Devel)
Installed from:    Compiled sources

On displaying the contents  an automatically detected camera, USB mass storage or card reader, the Camera GUI window title includes a '&'.

I guess that's the accelerator from the menu Action.
Comment 1 Andi Clemens 2009-01-08 11:19:29 UTC
Right, but only on auto detected devices, not when importing from folders.

I will have a look on it...

Andi
Comment 2 Andi Clemens 2009-01-08 12:38:43 UTC
SVN commit 907543 by aclemens:

Remove single ampersand characters from action text to avoid displaying them in the CameraUI window title.
Since single ampersand is used for accelerator shortcuts, we don't need
to display them in the window title.

CCBUG:180006

 M  +8 -1      digikamapp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=907543
Comment 3 Andi Clemens 2009-01-08 12:39:34 UTC
Is there a better solution then this one? If not, I think we can close it again.

Andi
Comment 4 Will Stephenson 2009-01-08 12:52:49 UTC
Darn, you made me think about it!

QString QAction::iconText() uses a strip function in qaction.cpp to clean up the icon text without using a QRegExp.  I tried that and it's clean, just use it instead of QAction::text(). 
Comment 5 Andi Clemens 2009-01-08 13:02:11 UTC
Oh yes, right!!
This was nearly too easy :-)
Comment 6 Andi Clemens 2009-01-08 13:08:02 UTC
SVN commit 907551 by aclemens:

use iconText() instead of a RegEx to remove ampersand characters from CameraUI window title

BUG:180006

 M  +1 -7      digikamapp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=907551
Comment 7 Will Stephenson 2009-01-08 13:26:37 UTC
Thanks for looking at it :)
Comment 8 Salvatore Brigaglia 2009-01-24 17:40:29 UTC
(In reply to comment #7)
> Thanks for looking at it :)
> 

I think this whould be reopened as of today (r916085) the "&" is shown on my auto-detected canon 350D
Comment 9 Andi Clemens 2009-01-24 18:21:05 UTC
Are you sure that the character is not a part of your card's or camera's name?
Can you provide a screenshot of the problem (if possible with the menu entry as well)?

Andi
Comment 10 Salvatore Brigaglia 2009-01-24 18:27:55 UTC
(In reply to comment #9)
> Are you sure that the character is not a part of your card's or camera's name?
> Can you provide a screenshot of the problem (if possible with the menu entry as
> well)?
> 
> Andi
> 

Andi,

The menu entry did not contains any "&". Screenshot and terminal output in some minutes ;)
Comment 11 Salvatore Brigaglia 2009-01-24 18:46:04 UTC
(In reply to comment #10)
> (In reply to comment #9)
> > Are you sure that the character is not a part of your card's or camera's name?
> > Can you provide a screenshot of the problem (if possible with the menu entry as
> > well)?
> > 
> > Andi
> > 
> 
> Andi,
> 
> The menu entry did not contains any "&". Screenshot and terminal output in some
> minutes ;)
> SunLocator::update()                                                                                                                  
digikam(16536)/digikam (core) Digikam::DigikamApp::checkSolidCamera: fillSolidMenus: Found Camera  " USB Imaging Interface"  protocols  ("ptp")  drivers  ("gphoto")
digikam(16536)/digikam (core) Digikam::DigikamApp::openSolidCamera: Found camera from ids  1193   12527  camera is:  "Canon EOS 350D"  at  "usb:"                   

Comment 12 Salvatore Brigaglia 2009-01-24 18:47:27 UTC
Created attachment 30564 [details]
Camera gui showing & before camera name
Comment 13 Andi Clemens 2009-01-24 20:03:27 UTC
SVN commit 916170 by aclemens:

Use iconText() for openSolidCamera() as well

CCBUG:180006

 M  +1 -1      digikamapp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=916170
Comment 14 Andi Clemens 2009-01-24 20:04:33 UTC
Salvatore,

can you checkout the latest revision to see if the bug has been fixed now?

Andi
Comment 15 Salvatore Brigaglia 2009-01-24 20:55:00 UTC
> can you checkout the latest revision to see if the bug has been fixed now?
> 
> Andi
> 

Another little bug squashed in a couple of hours. You guys are amazing!

Keep it as closed...