Bug 179988

Summary:	Chat Window Tabs should have option for Left and Right of the Chat Window
Product:	[Unmaintained] kopete	Reporter:	Cameron Seader <cseader>
Component:	general	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	jabrazavi
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Adds option for Left and Right tab placement to kopete

Description Cameron Seader 2009-01-08 05:52:50 UTC

Version:           4.1.87 (using Devel)
OS:                Linux
Installed from:    Compiled sources

for a long time Kopete has been lacking in this enhancement. Pidgin has offered this for a long time. I always love having my chat window tabs on the left side of the chat window. I would like to see these options added to kopete for having the chat window tabs on either the Left or Right side of the Chat window in addition to the current options of Top and Bottom of Chat Window.

Comment 1 Joseph A. B. Razavi 2009-09-11 20:40:43 UTC

Created attachment 36876 [details]
Adds option for Left and Right tab placement to kopete

This patch should add left and right to the tab placement menu, and clicking them has the desired effect. I think this also solves #143835. Note, this is my first ever patch to any project, and even though it consists of only a few lines' change, it is probably worth sanity checking it. If I have done something wrong in there or in the submission process and someone emails me feedback I would be very grateful. Thanks.

Comment 2 Joseph A. B. Razavi 2009-09-11 20:42:23 UTC

I forgot to say, I was working from the 4.2 stable relese, although I don't think the part of the file which needs to be changed has changed since then.

Comment 3 Joseph A. B. Razavi 2009-09-11 21:43:53 UTC

Sorry, I just noticed that this patch will cause a minor bug, if you reorder the tabs while in side mode they will shrink to a small size. More reading for me. Sorry again.

Comment 4 Matt Rogers 2009-09-11 23:44:16 UTC

I'll commit it anyways, and if you want to fix the resize bug, then just
post another patch, either in a new bug or on the reviewboard.

Comment 5 Matt Rogers 2009-09-12 05:52:14 UTC

SVN commit 1022574 by mattr:

Add the ability to put tabs on the left or right in the chatwindow

Patch by Joseph Razavi. Thanks!

FEATURE: 179988

 M  +14 -6     kopetechatwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1022574

Comment 6 Joseph A. B. Razavi 2009-09-12 12:58:47 UTC

Cool, thanks. (I hope this message doesn't spam a mailing list somewhere, sorry if it does)