Bug 179933

Summary: context menu of top "My Albums" isn't right
Product: [Applications] digikam Reporter: Mikolaj Machowski <mikmach>
Component: Usability-MenusAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: marcel.wiesweg
Priority: NOR    
Version: 0.10.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In: 0.10.0
Sentry Crash Report:

Description Mikolaj Machowski 2009-01-07 19:22:04 UTC 
Version:            (using Devel)
Compiler:          gcc4.3.2 
OS:                Linux
Installed from:    Compiled sources

In Albums panel we have situation:

My Albums      ^        (header, thanks Andi for arrow :)
- My Albums             (root album)
-- Collection           (collection)
--- Album               (regular photo album)

I am writing about second "My Albums". There are two problems:

- awkward repetition My Albums - My Albums (also exists in Tag panel); is root collection/tag really necessary at all?

- issue of context menu specific for Albums panel; when accessing context menu and "New" item in all other elements it will create child of clicked element; not in this case - it will create child of first collection - two levels down; small problem if we have one collection but things can get vague with more than one; 

simplest solution: remove access to this context menu; 

intermediate solution: "New collection..." give direct access to creation of new collections

radical solution: get rid of root album.
Comment 1 Marcel Wiesweg 2009-01-08 19:28:35 UTC 
SVN commit 907769 by mwiesweg:

Remove useless popup menu at to the root album item in AlbumFolderView.

CCBUG: 179933

 M  +5 -5      albumfolderview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=907769
Comment 2 Marcel Wiesweg 2009-01-08 19:34:47 UTC 
Implemented the simplest solution, and marking not as FIXED but as WISH to remind me of the other two options.
I usually like the topmost root item because of tradition and because it gives an optical bracket...conceding its reason of existence is only the tree implementation of the internal album structure in memory. I am thinking of putting an icon into the header view, so that it looks as the top level item now but the duplication is removed. Anyway, not for 0.10.
Comment 3 Mikolaj Machowski 2009-01-08 20:54:53 UTC 
Other simple solution about duplication (drat, why I didn't think about this?) is to just change wording. Suggestion: Albums and Tags for panel headers (cold application space) vs. My Albums (personal space inside of album. A bit silly but I really hate duplication in wording :)
Comment 4 Marcel Wiesweg 2009-01-08 22:25:10 UTC 
SVN commit 907888 by mwiesweg:

Remove duplication in wording, following Mikolaj's suggestion

CCBUG: 179933

 M  +1 -1      albumfolderview.cpp  
 M  +1 -1      tagfolderview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=907888
Comment 5 Mikolaj Machowski 2009-01-09 01:37:09 UTC 
Thanks. For me it fullfills all points.