Bug 179802

Summary:	After raw import image not shown in editor
Product:	[Applications] digikam	Reporter:	Gandalf Lechner <gandalflechner>
Component:	Plugin-RawImport-Native	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	marcel.wiesweg
Priority:	NOR
Version:	0.10.0
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:	1.0.0
Sentry Crash Report:
Attachments:	Embedded profile dialog Import dialog without embedded profile No embedded profile conversion result

Description Gandalf Lechner 2009-01-06 14:52:05 UTC

Version:           0.10.0-rc1 (rev.: 906212) (using 4.1.85 (KDE 4.1.85 (KDE 4.2 Beta2)), Kubuntu packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.27-7-generic

With color management enabled, and the option "ask when opening an image in the image editor" selected, the raw converter shows the following bug: After the conversion, clicking on "import" should open the decoded image in the image editor. But the image editor shows only the blank background in this case. However, for example a "zoom 100%" displays the image properly.

With color management switched off, or with enabled color management but selected "apply when opening an image in the image editor" selected, I did not see this bug.

Comment 1 Marcel Wiesweg 2009-01-29 23:09:32 UTC

Gilles you understand more about color profiles than me.
I see two bugs in this area:
If an image has an embedded profile, the result from "Convert" is the same as from "Assign". The preview for "Convert" however, is different. See first following screenshot.

If an image has no embedded profile, the conversion preview does not match the conversion result. See the following screenshot 2 and 3. Here, the result from "Convert" is different from "Assign", but the preview gives a third version.

In all cases I cannot say what should be the correct result, but obviously, something is wrong here.

Comment 2 Marcel Wiesweg 2009-01-29 23:11:07 UTC

Created attachment 30726 [details]
Embedded profile dialog

Image with embedded profile. The preview for "Convert" in the dialog is darker, both "Convert" or "Assign" will not change the output in the main view.

Comment 3 Marcel Wiesweg 2009-01-29 23:15:25 UTC

Created attachment 30727 [details]
Import dialog without embedded profile

This image has no embedded profile. See how the "Convert" thumbnail is very bright.

Comment 4 Marcel Wiesweg 2009-01-29 23:17:31 UTC

Created attachment 30728 [details]
No embedded profile conversion result

Now this is the result from "Convert". The preview was brighter than the original, now the result is darker (and does not match the preview)

Comment 5 Marcel Wiesweg 2009-01-31 23:42:51 UTC

This might be the same problem as the one described in 182272. See the test images linked there in comment #1.

Comment 6 caulier.gilles 2009-02-04 06:32:24 UTC

Marcel,

There is a good introduction to CM here :

http://tb3.org/linux-color-management/

I must review code of CM in digiKam. still in my todo list...

Gilles

Comment 7 Marcel Wiesweg 2009-08-23 20:51:37 UTC

With the recent color management rewrite this bug is solved for me. When I select RAW output colors in the import tool and "Ask user for profile" in the settings for uncalibrated data, I click on import, get the dialog to select and input profile with a working preview and the uncorrected image already in the background.