Bug 179653

Summary: "Filter active" icon not set if filter is "rating equals zero stars"
Product: [Applications] digikam Reporter: Ian Hubbertz <kde_bugs>
Component: Albums-FiltersAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: 0.10.0   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In: 0.10.0
Sentry Crash Report:
Attachments: Patch that should solve the problem

Description Ian Hubbertz 2009-01-04 23:00:00 UTC 
Version:           0.10.0-beta7 (using Devel)
OS:                Linux
Installed from:    Compiled sources

Set rating filter to zero stars and condition to "equals". --> The filter indicator in the status bar remains off (white/grey).

Wished behaviour: It should switch green or red respectively.
Comment 1 Ian Hubbertz 2009-01-04 23:35:29 UTC 
Created attachment 29912 [details]
Patch that should solve the problem

Now a filter is recognized if the rating filter is != 0 stars OR the condition is not greaterEqual.

Due to other compile errors (marble integration), I was not able to compile and test the patch.
Comment 2 caulier.gilles 2009-01-05 06:01:02 UTC 
Andi, Marcel,
 
0.10.0-Beta8 tarball is not yet released. We can trying to include this patch today if we test it soon.

Gilles Caulier
Comment 3 caulier.gilles 2009-01-05 09:05:18 UTC 
SVN commit 905821 by cgilles:

fix rating filter rules if filter is "rating equals zero stars"
CCBUG: 179653


 M  +3 -0      albumiconviewfilter.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=905821
Comment 4 caulier.gilles 2009-01-05 09:31:13 UTC 
SVN commit 905829 by cgilles:

backport commit #905821 from KDE3 branch
BUG: 179653


 M  +2 -3      albumiconviewfilter.cpp  
 M  +1 -1      albumiconviewfilter.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=905829
Comment 5 Ian Hubbertz 2009-01-05 13:05:34 UTC 
> fix rating filter rules if filter is "rating equals zero stars"
> CCBUG: 179653
> 
> 
>  M  +3 -0      albumiconviewfilter.cpp  

In kde3 branch, you didn't remove the old line, so for a rating filter != 0, "Rating" is added twice to the filtersList.
Comment 6 caulier.gilles 2009-01-05 13:13:32 UTC 
SVN commit 905929 by cgilles:

missing to remove old lines with previous commit
CCBUGS: 179653


 M  +1 -4      albumiconviewfilter.cpp  
 M  +1 -1      albumiconviewfilter.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=905929