| Summary: | khelpcenter: clicking on the arrows in the subgroups of the application manuals, doesn't expand the groups | ||
|---|---|---|---|
| Product: | [Applications] khelpcenter | Reporter: | Panagiotis Papadopoulos <pano_90> |
| Component: | general | Assignee: | Cornelius Schumacher <schumacher> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | davidben, lueck |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Schedule TOC builds during a setOpen | ||
|
Description
Panagiotis Papadopoulos
2009-01-02 23:32:29 UTC
Created attachment 42731 [details]
Schedule TOC builds during a setOpen
Confirmed on KDE 4.4.2 built from source.
I think this patch should address it. I move the TOC build to be an internal function of the NavigatorItem and schedule it on setOpen. This resolves the reported problem, as well as the lack of auto-expanding when we move to a different page via a link.
Hmm, somehow I don't have this bug in recent trunk and branch compiled from sources here. Without the patch from comment #2 I can: 1) start khelpcenter 2) click on "Application Manuals" -> the categories are displayed in the navigator view and in the right window part 3) click on the "+" (branch) or ">" (trunk) in front of e.g. the category "Internet" without clicking the category "Internet" -> all available application handbooks in this category are now displayed in the navigator view, no change in the in the right window part. Applying the patch I see no different behaviour. Either I don't understand where the bug is or I don't have it here. Strange! Can soneone enlight me please? This only happens when you expand/collapse a particular *application's* manual. The original bug report is worded poorly. He (I presume) meant the submenus of the Internet menu, i.e., the individual apps within Internet. SVN commit 1124661 by lueck: Schedule TOC builds as part of a setOpen, , patch by David Benjamin This should fix items not expanding when selected via the arrow. They also sometimes fail to expand when navigating to the page. CCMAIL:davidben@mit.edu BUG:179427runtime/khelpcenter/navigator.cpp M +21 -2 navigatoritem.cpp M +1 -2 navigatoritem.h M +0 -2 toc.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1124661 SVN commit 1124667 by lueck: backport from trunk:Schedule TOC builds as part of a setOpen, patch by David Benjamin CCMAIL:davidben@mit.edu CCBUG:179427 M +1 -24 navigator.cpp M +21 -2 navigatoritem.cpp M +1 -2 navigatoritem.h M +0 -2 toc.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1124667 |