Bug 178823

Summary: Selected icon theme is still selected after changing module inside Appearance and discarding changes
Product: [Applications] systemsettings Reporter: Dario Andres <andresbajotierra>
Component: kcm_iconsAssignee: Marie Loise Nolden <nolden>
Status: RESOLVED FIXED    
Severity: normal CC: finex
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Proposed patch

Description Dario Andres 2008-12-26 18:48:52 UTC 
Version:           KDE: 4.1.86 (KDE 4.1.86 (KDE 4.2 >= 20081221)) kdelibs svn rev. 901624 / kdebase svn rev. 901624 (using Devel)
Compiler:          gcc 
OS:                Linux
Installed from:    Compiled sources

Here using:
Qt: 4.4.3 + qt-copy-patches-889120
KDE: 4.1.86 (KDE 4.1.86 (KDE 4.2 >= 20081221))
kdelibs svn rev. 901624 / kdebase svn rev. 901624
on ArchLinux x86_64 - Kernel 2.6.27.10

You need to have more than one Icon Theme installed.

Steps to Reproduce:

- Open System Settings
- Go to Appearance
- Click on Icons module
(Your active icon theme (and selected) is Oxygen)
- Click on another icon theme on the list
- Now, go to another Appearance module (ex. Colors)
An "Unsaved Changes" window appears.
- Click "Discard" in the "Unsaved Changes" window
You are now in another Appearance module (ex. Colors)
- Click again in Icons module
The recently selected (but no active) icon theme is still selected.

Also, If you click on the active theme (ex. Oxygen), clicking to another Appearance module will bring up the "Unsaved Changes" window, however , no real changes have been made since the Oxygen icon theme is the active theme (I never changed the active theme in this example)
Comment 1 FiNeX 2008-12-26 18:57:58 UTC 
I confirm this bug :-)

Thanks Dario!
Comment 2 Dario Andres 2008-12-28 22:42:33 UTC 
Created attachment 29707 [details]
Proposed patch

Select the current icon them on the load function (called when leaving the widget too)
Comment 3 FiNeX 2008-12-28 23:44:30 UTC 
SVN commit 902673 by finex:

Select correct icon theme on loading.
Patch by Dario Andres.

Tested and approved by me.

BUG: 178823



 M  +3 -0      iconthemes.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=902673