| Summary: | Taskbar items have too much space above text but the bottom gets cut off | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | Alec Moskvin <alecm> |
| Component: | widget-taskbar | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andresbajotierra, aseigo, asraniel, notmart, ruchir.brahmbhatt |
| Priority: | NOR | Keywords: | triaged |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
This is in KDE 4.1.85 (KDE 4.2 Beta2)
Screenshot: taskbar Ok Still looks exactly the same in KDE 4.2.91 Patch to center the text inside the task item Screenshot with patch applied |
||
|
Description
Alec Moskvin
2008-12-26 04:20:00 UTC
Created attachment 29631 [details]
This is in KDE 4.1.85 (KDE 4.2 Beta2)
And in an inpolite manner of bug hijacking i would like to mention that the text is also not correctly aligned in the group popup of the taskbar, when the panel is verticaly aligned. Here it's how it looks. http://www.fryx.ch/Asraniel/taskgroup.png Fell free to ignore this, but since the same code is probably responsible, this might be usefull. really weird, i have the exact opposite problem (text goes too high), font metrics are evil.. @Beat Wolf: no, it's not the same code, and i doubt it has anything to do with vertical vs horizontal either =) SVN commit 901833 by aseigo: fix up group list CCBUG:178776 M +7 -3 tasksmenu.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=901833 Can you still reproduce this bug with a recent KDE (4.1.4 / 4.2.2 / 4.2svn / 4.3svn) ? Thanks :) Darío Andrés, I updated to KDE 4.2.2 today and I can still reproduce this bug. Thanks for updating Here using: Qt: 4.5.0 + qt-copy-patches-942255 KDE: 4.2.70 (KDE 4.2.70 (KDE 4.3 >= 20090415)) kdelibs svn rev. 958964 / kdebase svn rev. 958965 on ArchLinux i686 - Kernel 2.6.29.1 I can't reproduce. Attaching screenshot Created attachment 33098 [details]
Screenshot: taskbar Ok
I also can't reproduce. I kept panel height less but font's don't cut. Sorry, but I'm still getting the exact same problem... Qt: 4.5.1 KDE: 4.2.91 (KDE 4.2.91 (KDE 4.3 >= 20090609)) Created attachment 34502 [details]
Still looks exactly the same in KDE 4.2.91
the new screenshot doesn't show any fonts being cut off, it shows the text being rendered outside the button's visual border area. the font is aligned to the top of the button's visual area in that shot, so it seems to my eyes that the issue is that the buttons are allowed to go a bit too small (e.g. there should be just one row there, not two) ... but i don't see font rendering issues there. Aaron, I never said it was rendered incorrectly - it's just not centered properly. Here's a patch! Created attachment 34527 [details]
Patch to center the text inside the task item
The code was checked out from:
svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/plasma/applets/tasks/
Created attachment 34796 [details]
Screenshot with patch applied
If anyone doubts it, here's a screenshot of a really thin task bar with the patch applied. As you can see, the text does not get cut off.
The patch removed two things: (1) code that sets the text at (0, 0) if the "text" is larger than the rectangle (which is not correct since there is additional interline spacing added to top and bottom which need not be shown), and (2) the part where it for some strange reason lowers all the text by the difference between the height of the 'M' and the 'x', thus pushing it out of the drawable area.
Marking bug as fixed. Fix is here: http://reviewboard.kde.org/r/980/ Commit is here: http://websvn.kde.org/?view=rev&revision=999679 |
