Bug 178701

Summary:	"Move File to Collection" Completely Deletes File Without Permissions
Product:	[Applications] amarok	Reporter:	Nathan <reformer81>
Component:	Collections/Local	Assignee:	Amarok Bugs <amarok-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	reformer81, teo
Priority:	VHI	Keywords:	release_blocker
Version First Reported In:	2.0
Target Milestone:	---
Platform:	Ubuntu
OS:	Unspecified
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Nathan 2008-12-25 00:36:51 UTC

Version:           2.0 (using KDE 4.1.3)
Installed from:    Ubuntu Packages

When using the File Browser to move music files to the "Local Collection," if the user does not have write permissions for the Collection directory, the files are deleted without any notification.

Possible fix would be to check permissions BEFORE the attempt to move.  Or at the very least, verify the file is in the destination directory BEFORE deleting original.

Comment 1 Lydia Pintscher 2008-12-25 21:11:50 UTC

Teo: Was this fixed already?

Comment 2 Maximilian Kossick 2008-12-26 20:10:09 UTC

SVN commit 901828 by mkossick:

do not delete files if an error occured during the file transfer
@devels: this has been fixed for SqlCollection, i.e. moves from the local collection or "organize files"
all other implementations of CollectionLocation have to be fixed too, especially MTP/iPod
BUG: 178701
CCMAIL: amarok-devel@kde.org


 M  +16 -1     CollectionLocation.cpp  
 M  +6 -0      CollectionLocation.h  
 M  +8 -3      sqlcollection/SqlCollectionLocation.cpp  
 M  +1 -1      sqlcollection/SqlCollectionLocation.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=901828