Summary: | undo button or function missing | ||
---|---|---|---|
Product: | [Applications] okular | Reporter: | Patrick Fehr <fehrp.box> |
Component: | general | Assignee: | Okular developers <okular-devel> |
Status: | RESOLVED FIXED | ||
Severity: | wishlist | CC: | aacid, alessanderbotti, alvaro.aguilera, jackdachef, jrtayloriv, meyerm, mutlu_inek |
Priority: | NOR | ||
Version: | 0.7.2 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | http://commits.kde.org/okular/b7ce9114c56a08770cc2f45abd67ca7d2f8dec51 | Version Fixed In: | 4.11.0 |
Description
Patrick Fehr
2008-12-11 16:26:24 UTC
> And it is a bug, that sometimes my annotations don't get saved even if I save
> them.
You cannot "save" annotations. What do you really mean?
(Again, offtopic wrt the bug topic.)
This is a big PITA. Given that the yellow highlighter doesn't work that well with non-trivial page layouts, I find myself deleting wrong marks as soon as I start marking something. With the current version of okular, you have to open the navigation sidebar, go to reviews, look for the last one and delete it. An "undo" option (with the usual Ctrl+Z shortcut) would make life a lot easier. Another usability improvement would be to leave the highlighter tool selected after marking something. Again, with a non-trivial layout, you not only have to mark line by line, but also select the highlighter tool every single time. +1 for this request. I sometimes find myself marking a wrong sentence and would love to be able to press Ctrl-Z and undo the last review action. Would be a big timesaver. *** Bug 229269 has been marked as a duplicate of this bug. *** this bug is a REAL productivity-killer ! :( this still even seems to exist with okular 0.11.2 from KDE 4.5.3 (Gentoo ~amd64 with qt 4.7.1) please add an undo-functionality such as at least an undo-button or ctrl+z to undo it via an shortcut Many thanks in advance ! :) +1 for fixing this usability bug. Maybe I'll soon get around to setting up a development environment for KDE (I don't use KDE as a desktop), so I can write a patch for this. Basically, I was going to make it where whenever the Annotations toolbar is open, there will be Undo/Redo options listed in the Edit menu which will be connected by default with key shortcuts CTRL+Z/CTRL+R, respectively. Is there anyone that would have a problem with me adding this, before I take the time to get set up and write a patch? This is *not* a usability bug, it's a missing feature. That said, of course if you implement it it will be considered for inclusion. >Is there anyone that would have a problem with me adding this, before I take
>the time to get set up and write a patch?
I won't. Since you may encounter some resistance if your patches include words like "edit" or "undo", please announce them here so that people like me can apply them, even if they don't make it into the official version.
Thanks!
@Alvaro: "Since you may encounter some resistance if your patches include words like "edit" or "undo"" Sorry? *** This bug has been confirmed by popular vote. *** IIUC, this is fixed in trunk. Only for annotations, not for forms Git commit b7ce9114c56a08770cc2f45abd67ca7d2f8dec51 by Albert Astals Cid, on behalf of Jon Mease. Committed on 03/06/2013 at 22:46. Pushed by aacid into branch 'master'. Undo support for PDF forms Together with the already commited support for undo in annotations fixes 177501 REVIEW: 110589 FIXED-IN: 4.11.0 M +49 -0 core/document.cpp M +83 -0 core/document.h M +205 -0 core/documentcommands.cpp M +95 -1 core/documentcommands_p.h M +572 -65 ui/formwidgets.cpp M +119 -11 ui/formwidgets.h M +15 -10 ui/pageview.cpp M +1 -1 ui/pageview.h http://commits.kde.org/okular/b7ce9114c56a08770cc2f45abd67ca7d2f8dec51 |