| Summary: | JJ: amarok does not remove leading blanks in podcast titles | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | andreaswuest |
| Component: | Podcast | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | bart.cerneels, IsolatedIncident, joerg-schumann |
| Priority: | NOR | Keywords: | junior-jobs |
| Version: | 2.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: |
screenshot showing the leading blanks
remove redundant whitespace |
||
Created attachment 29215 [details]
screenshot showing the leading blanks
Noted. I need to take measures to limit the width of the episodes titles anyway. In 1.4 I did this by removing the common part in episode and channel titles, i.e. using Amarok::decapitateString() again. It won't work for this specific channel, it just needs some white-space pruning. This is a good Junior Job, or a weekend project for me. There are other more urgent things on the TODO though. I'm looking into this bug. I've been able to confirm the problem. I'm just not certain what exactly is desired. Should I be attempting to strip out extraneous white space from the podcast episode titles, limiting their length to a certain length, or both? As for limiting the length of titles, it can be done with QFontMetrics::elidedText(): http://doc.trolltech.com/4.4/qfontmetrics.html#elidedText Created attachment 32836 [details]
remove redundant whitespace
Hi,
I've put together something. What do you think of it? Any side effects?
It doesn't limit the text length, though. I have no idea what a reasonable max. length would be...
50 characters, 100, 200?
SVN commit 954182 by seb: Strip unnecessary whitespace from podcast titles. BUG: 177403 CCMAIL: joerg-schumann@gmx.net M +1 -0 ChangeLog M +4 -1 src/podcasts/PodcastReader.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=954182 |
Version: 2.0 (using 4.1.3 (KDE 4.1.3), Kubuntu packages) Compiler: cc OS: Linux (x86_64) release 2.6.27-9-generic hello, for some reason the swr3 podcast does sometimes contain a leading blank in the podcast title, which does not really look nice in amarok (see attached) screenshot. it would be nice if amarok could remove leading blanks in the podcast title: <item> <title> Thailands Regierungspartei verboten - Flughafen Bangkok nimmt den Betrieb wieder auf</title><itunes:author>SWR3.online</itunes:author> <itunes:keywords>Topthema Bangkok 2.12.08</itunes:keywords> ...... cheers, andy