Bug 177329

SVN commit 900460 by cgilles:

digiKam from trunk : add new option to match search text bar everywhere in sensitive case or not.
The option is in context menu of search text bar where user enter string to match.
By default, the option is dsable.
BUG: 162206
BUG: 177329


 M  +7 -8      digikam/albumfolderview.cpp  
 M  +2 -1      digikam/albumfolderview.h  
 M  +4 -5      digikam/albumiconviewfilter.cpp  
 M  +2 -1      digikam/albumiconviewfilter.h  
 M  +10 -10    digikam/albumlister.cpp  
 M  +2 -1      digikam/albumlister.h  
 M  +7 -9      digikam/albumselectdialog.cpp  
 M  +5 -1      digikam/albumselectdialog.h  
 M  +15 -16    digikam/digikamview.cpp  
 M  +1 -0      digikam/digikamview.h  
 M  +7 -8      digikam/tagfilterview.cpp  
 M  +2 -1      digikam/tagfilterview.h  
 M  +7 -8      digikam/tagfolderview.cpp  
 M  +2 -1      digikam/tagfolderview.h  
 M  +5 -9      libs/dialogs/rawcameradlg.cpp  
 M  +2 -1      libs/dialogs/rawcameradlg.h  
 M  +13 -14    libs/imageproperties/imagedescedittab.cpp  
 M  +3 -2      libs/imageproperties/imagedescedittab.h  
 M  +33 -2     libs/widgets/common/searchtextbar.cpp  
 M  +28 -1     libs/widgets/common/searchtextbar.h  
 M  +4 -4      libs/widgets/metadata/metadatalistview.cpp  
 M  +2 -1      libs/widgets/metadata/metadatalistview.h  
 M  +3 -3      libs/widgets/metadata/metadatawidget.cpp  
 M  +3 -1      project/project.kdevelop  
 M  +3 -4      utilities/fuzzysearch/fuzzysearchfolderview.cpp  
 M  +2 -1      utilities/fuzzysearch/fuzzysearchfolderview.h  
 M  +2 -2      utilities/fuzzysearch/fuzzysearchview.cpp  
 M  +4 -5      utilities/gpssearch/gpssearchfolderview.cpp  
 M  +2 -1      utilities/gpssearch/gpssearchfolderview.h  
 M  +2 -2      utilities/gpssearch/gpssearchview.cpp  
 M  +21 -25    utilities/kipiiface/kipiimagecollectionselector.cpp  
 M  +4 -3      utilities/kipiiface/kipiimagecollectionselector.h  
 M  +9 -11     utilities/kipiiface/kipiuploadwidget.cpp  
 M  +2 -1      utilities/kipiiface/kipiuploadwidget.h  
 M  +3 -4      utilities/searchwindow/searchfolderview.cpp  
 M  +2 -1      utilities/searchwindow/searchfolderview.h  
 M  +5 -6      utilities/setup/cameraselection.cpp  
 M  +5 -1      utilities/setup/cameraselection.h  
 M  +3 -4      utilities/timeline/timelinefolderview.cpp  
 M  +2 -1      utilities/timeline/timelinefolderview.h  
 M  +2 -2      utilities/timeline/timelineview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=900460

Mik,

Look my commit #900460 !

Please test all parts where search text bar exist and report if you see any regression.

Thanks in advance

Gilles Caulier

Works perfectly for Album list and Main window but quick search field in Caption/Tags doesn't follow policy - filtering is always case insensitive.

Mik,

Fixed with commit #900825.

Please check too these search tools: 

- Metadata side bar.
- all folder view (Tags filter, Searches, Tags, TimeLine, Fuzzy Searches, Map Searches) 
- Camera settings page.

Thanks in advance

Gilles

This time proper testing:

Due to number of issues here I will reopen bug.

Everywhere: default completion should be "Dropdown list", it is default for whole KDE and it should be default also for digiKam. Also "Automatic" has side effect - current list is filtered against current guess. Example: enter m, automatic completion is filled with Michelle and only those item is shown although there are other elements which match this letter (Amy, Kamila, etc.)

Everywhere: "Dropdown list" is filled only according to expression "m*" while items in list are filtered to "*m*". Cognitive distruption.

IMO unless two things are solved completion in quick filter fields should be disabled. And frankly - I don't think it is worth of fixing. Quick filter is only to narrow number of possible choices not to get precise one element.

Albums: when option is case insensitive after some letters I get no matches although I know those elements are there, after inserting second letter filtering is done right (letters k, g, s, i, e but not p, r). "No matches" means tree is folded to root album - *real* no matches means everyghing vanishes

This issue occurs only in this panel.

Timeline: Stranely looking thing with Last Search. This item has double name Last Search and Current Search and although only one name is visible it is filtered by both names. The best solution would be exclude this from all filtering acitivities (item should be always visible, maybe different font to differentiate from other searches).

Searches: This time Last Search/Current Search is to filter known *only* as Current Search even when Last Search is visible.

Geo: cannot test, no sufficient

Metadata (right panel): This one is weird. 

Case sensitive - insert "caption" shows "Caption", insert "Caption" shows nothing
Case insensitive - works OK

Note: when filtering out whole sections (like Image Information), header of this section should aslo vanish.

>Everywhere: default completion should be "Dropdown list" 

This can be configured from contextual menu.

>Everywhere: "Dropdown list" is filled only according to expression "m*" while >items in list are filtered to "*m*"

Here we manage nothing. this code come from KLineEdit code from KDElibs.

For all others points, i need to check indeep in code.

Gilles

>Metadata (right panel): This one is weird. 

Fixed with commit #900883.

Gilles

Andi,

With this comment :

>Albums: when option is case insensitive after some letters I get no matches >although I know those elements are there, after inserting second letter >filtering is done right (letters k, g, s, i, e but not p, r). "No matches" means >tree is folded to root album - *real* no matches means everyghing vanishes This >issue occurs only in this panel. 

Something is wrong with recursive tree parsing and search filter ? you have patched something about if i remember...

Gilles

I didn't change the parsing, only the collapsing of the tree. I don't really understand the problem either, for me filtering works perfectly fine, in case sensitive and insensitive mode.

Mik, can you describe this a little bit more?

Note: I'll be at my relatives for 3 days now, I will have my notebook with me but I don't know if I can / will be online.

Andi

#9, Andi

I have albums tree (examples, not everything):

/home/mikolaj/Imgs
- 2008-11-20
- 2008-12-22
- ekslibrisy
- grafika
- inne
- KrCoSt
- Kreta 2008
- rysunki

I set albums quick search for case insensitive and insert k (or K, doesn't matter)

Whole tree collapses to

/home/mikolaj/Images

Background of quick search is green so digiKam *knows* there are matches, just doesn't display them. If I add second k everything vanishes and background of quick search field becomes red - proper reaction. When I add r (result kr) I get correct result (the same for all other existing combinations).

/home/mikolaj/Imgs
- KrCoSt
- Kreta 2008

More systematic approach:

Letters which are working: b, c, d, f, n, p, q, r, t, u, v, w, x, y, z 
Letters which are not: a, e, g, h, i, j, k, l, m, o, s

What completion mode are you using? I can not confirm this at the moment, here it filters fine.
I'll go through all letters now (dropdown list mode, case insensitive) to see if I can reproduce the issue on my machine.

Andi

Due to problems I reported earlier I turned off completion completely.

SVN commit 903498 by aclemens:

fix quick search: always expand albumroot folders, otherwise not all
search results are visible. Also make sure to avoid root and albumroot
folder items when looking for parent matches.

CCBUG:177329

 M  +11 -7     albumfolderview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=903498

Mik,

quick search should be fixed now. Can you confirm this?
The problem occured when the letters where in the albumroot name. With too few matching characters, the albumroot folder was just collapsed.

Andi

Good news for Andi: yes, this issue was fixed.

Is there anything else left to fix?

Andi

This one is left:

Searches: This time Last Search/Current Search is to filter known *only* as
Current Search even when Last Search is visible.

SVN commit 907906 by mwiesweg:

Use viewItem's text for search bar filtering, so that Last Search / Current Search is found

CCBUG: 177329

 M  +2 -5      searchfolderview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=907906

Last point describe in #17 is now fixed by commit #907906.

I close this file.

Gilles Caulier