Bug 177212

Summary:	"Error Loading Image" on desktop should quietly move to next image
Product:	[Unmaintained] plasma4	Reporter:	Dotan Cohen <kde-2011.08>
Component:	widget-frame	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	wishlist	CC:	asraniel, gregor, kde-2011.08
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Unspecified
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Dotan Cohen 2008-12-08 11:34:49 UTC

Version:            (using KDE 4.1.3)
Installed from:    Ubuntu Packages

Currently the Picture Frame desktop widget gives an "Error Loading Image" message if it cannot find the image that it wants to display (for instance, if images were erased from the hard drive). Instead of that error, the widget should quietly choose a new image and move on. An error should be given only if the widget has exhausted it's list of images and cannot find any.

Comment 1 Gregor Tätzner 2011-10-29 08:17:05 UTC

This is a duplicate of report 212818 - kind of

Comment 2 Dotan Cohen 2011-10-30 13:48:42 UTC

1) Bug #212818 refers to instances in which a valid .jpg file is not displaying, whereas this bug refers to instance in which the path to an image is incorrect.

2) Obviously not a dupe of a newer bug!

Comment 3 Aaron J. Seigo 2011-10-31 10:08:03 UTC

Git commit 2d948694b262444fd938bbb94065ee6e61a43417 by Aaron Seigo.
Committed on 31/10/2011 at 11:06.
Pushed by aseigo into branch 'master'.

handle deleted pictures in a slideshow more gracefully by just skipping them

deletion handling inspired by a patch by Greg T
also cleans up a bunch of method signatures and improves the setUrl index bounds handling

REVIEW:103001
BUG:177212

M  +1    -1    applets/frame/frame.cpp
M  +15   -4    applets/frame/picture.cpp
M  +4    -1    applets/frame/picture.h
M  +43   -22   applets/frame/slideshow.cpp
M  +3    -2    applets/frame/slideshow.h

http://commits.kde.org/kdeplasma-addons/2d948694b262444fd938bbb94065ee6e61a43417

Comment 4 Dotan Cohen 2011-10-31 13:55:56 UTC

Thanks Aaron!