Bug 176171

Summary:	Right-clicking a magnatune album in the playlist and Buy gives the wrong buy box
Product:	[Applications] amarok	Reporter:	Pascal d'Hermilly <pascal>
Component:	Internet Services	Assignee:	Amarok Bugs <amarok-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nhn
Priority:	NOR
Version First Reported In:	2.0-rc
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Pascal d'Hermilly 2008-11-26 21:20:21 UTC

Version:           1.98 (using KDE 4.1.3)
OS:                Linux
Installed from:    Ubuntu Packages

I just bought an album in magnatune and when I wanted to buy another one I right-clicked it and selected Buy. I then again got the buy box for the album I just bought. At first I also had some trouble getting the buy box up for that one. I've tried opening the box several times, every time getting the wrong buy box.

When I right-click and select buy the album from the  Internet->Magnatune.com, then I get the right album.

Comment 1 Mark Kretschmann 2008-11-26 22:16:16 UTC

Nikolaj, any ideas?

Comment 2 Nikolaj Hald Nielsen 2008-11-27 07:57:54 UTC

The reason this fails is that the "buy" action on magnatune tracks are part of the custom action capability. These actions were never meant to be shown in the playlist, and this particular action operates based on what is selected in the Magnatune browser. 

Originally these actions were not shown in the playlist at all, but someone changed that recently it seems.

Comment 3 Nikolaj Hald Nielsen 2008-11-27 12:44:34 UTC

SVN commit 889617 by nhnielsen:

Fix using the "Purchase" or "Download" actions from the playlist starting a purchase or download of the wrong album.
Please give this a bit of testing ( just check that the purchase/download of the right album is initated no matter where this action is invoked from ( playlist, browser, tray icon, toolbar, or current track applet ) ). No need to actually purchase or download 
anything
BUG: 176171


 M  +1 -0      CMakeLists.txt  
 M  +70 -35    MagnatuneMeta.cpp  
 M  +13 -5     MagnatuneMeta.h  
 A             MagnatunePurchaseAction.cpp   [License: GPL (v2+)]
 A             MagnatunePurchaseAction.h   [License: GPL (v2+)]
 M  +33 -1     MagnatuneStore.cpp  
 M  +5 -1      MagnatuneStore.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=889617