| Summary: | starts to fetch album covers automatically when starting the cover manager | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Pascal d'Hermilly <pascal> |
| Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 2.0-SVN | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
|
Description
Pascal d'Hermilly
2008-11-26 21:12:16 UTC
Yes, I've seen this behaviour. It doesn't make sense to automatically retrieve cover art when opening the cover manager as this causes lock downs when we try fetch more than a few images at once. The simple fix would be to change CoverManager::loadCover() so that it only calls m_albumPtr->image() if hasImage() returns true. If !hasImage() we'd want to manually set the album cover to our nocover image. That'd be CoverViewItem, obviously. Also would need to change the ctor to do the same thing. Yes, this is a good workaround that I never considered. Good idea. Actually on further investigation this won't work since hasImage() simply calls checks whether image() returns a valid QPixmap. Well, the other solution that seems valid would be to not show the "Fetch missing covers" button if AmarokConfig::autoGetCoverArt() is set. It seems acceptable to me to do this, the user did configure automatic fetching, after all. After consideration, we should _never_ auto fetch all covers by using the inbuild SqlAlbum methods, because it does no queuing and does not know about any other fetch operations which are happening. SqlMeta _does_ use queueing...
From the source:
if( !m_name.isEmpty() && AmarokConfig::autoGetCoverArt() )
CoverFetcher::instance()->queueAlbum( AlbumPtr(this) );
I guess it does. Regardless, I don't think that we should start an automatic global fetch for 1000 albums, for example. It's fine to do it in the normal UI. SVN commit 952966 by seb: Don't automatically fetch all covers when opening the Cover Manager BUG: 176170 M +2 -0 ChangeLog M +2 -1 src/collection/sqlcollection/SqlMeta.cpp M +3 -0 src/collection/sqlcollection/SqlMeta.h M +9 -1 src/covermanager/CoverManager.cpp M +6 -1 src/meta/Meta.h WebSVN link: http://websvn.kde.org/?view=rev&revision=952966 |