Summary: | Using the filter on file browser tab does not work | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Attilio Scotolati <nexor> |
Component: | File Browser | Assignee: | David Faure <faure> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | amarok-bugs-dist, faure, lydia, shikamaru, shrikantkhare, simon |
Priority: | NOR | ||
Version: | 2.1-SVN | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Attilio Scotolati
2008-11-26 15:45:11 UTC
another backtrace Thread 1 (Thread 0x7f1d40c4d750 (LWP 9017)): #0 0x00007f1d3809a7e1 in nanosleep () from /lib/libc.so.6 #1 0x00007f1d3809a604 in sleep () from /lib/libc.so.6 #2 0x00007f1d3d1adf8b in ?? () from /usr/lib64/libkdeui.so.5 #3 0x00007f1d3d1ae70d in KCrash::defaultCrashHandler () from /usr/lib64/libkdeui.so.5 #4 <signal handler called> #5 0x00007f1d3d64b9f4 in ?? () from /usr/lib64/libkio.so.5 #6 0x00007f1d3d64ed70 in ?? () from /usr/lib64/libkio.so.5 #7 0x00007f1d3d64fe81 in KDirModel::qt_metacall () from /usr/lib64/libkio.so.5 #8 0x00007f1d39d8826c in QMetaObject::activate () from /usr/lib64/qt4/libQtCore.so.4 #9 0x00007f1d3d639095 in KDirLister::itemsDeleted () from /usr/lib64/libkio.so.5 #10 0x00007f1d3d643182 in KDirLister::emitChanges () from /usr/lib64/libkio.so.5 #11 0x00007f1d4040777f in FileBrowser::Widget::slotFilterChange (this=0x7f1d205130b0, nf=<value optimized out>) at /var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/browsers/filebrowser/FileBrowser.cpp:326 #12 0x00007f1d40407873 in FileBrowser::Widget::qt_metacall (this=0x7f1d205130b0, _c=QMetaObject::InvokeMetaMethod, _id=0, _a=0x7fff48da4d40) at /var/tmp/portage/media-sound/amarok-9999/work/amarok_build/src/FileBrowser.moc:121 #13 0x00007f1d39d8826c in QMetaObject::activate () from /usr/lib64/qt4/libQtCore.so.4 #14 0x00007f1d393d4102 in QComboBox::editTextChanged () from /usr/lib64/qt4/libQtGui.so.4 #15 0x00007f1d393dd90a in QComboBox::qt_metacall () from /usr/lib64/qt4/libQtGui.so.4 #16 0x00007f1d3d1f1c85 in KComboBox::qt_metacall () from /usr/lib64/libkdeui.so.5 #17 0x00007f1d3d203365 in KHistoryComboBox::qt_metacall () from /usr/lib64/libkdeui.so.5 #18 0x00007f1d39d8826c in QMetaObject::activate () from /usr/lib64/qt4/libQtCore.so.4 #19 0x00007f1d39411622 in QLineEdit::textChanged () from /usr/lib64/qt4/libQtGui.so.4 #20 0x00007f1d394169d6 in ?? () from /usr/lib64/qt4/libQtGui.so.4 #21 0x00007f1d39418c0e in QLineEdit::keyPressEvent () from /usr/lib64/qt4/libQtGui.so.4 #22 0x00007f1d3d20fe9b in KLineEdit::keyPressEvent () from /usr/lib64/libkdeui.so.5 #23 0x00007f1d39108679 in QWidget::event () from /usr/lib64/qt4/libQtGui.so.4 #24 0x00007f1d394190fb in QLineEdit::event () from /usr/lib64/qt4/libQtGui.so.4 #25 0x00007f1d3d20e0bb in KLineEdit::event () from /usr/lib64/libkdeui.so.5 #26 0x00007f1d393da341 in QComboBox::keyPressEvent () from /usr/lib64/qt4/libQtGui.so.4 #27 0x00007f1d3d202c21 in KHistoryComboBox::keyPressEvent () from /usr/lib64/libkdeui.so.5 #28 0x00007f1d39108679 in QWidget::event () from /usr/lib64/qt4/libQtGui.so.4 #29 0x00007f1d393d946d in QComboBox::event () from /usr/lib64/qt4/libQtGui.so.4 #30 0x00007f1d390bc2be in QApplicationPrivate::notify_helper () from /usr/lib64/qt4/libQtGui.so.4 #31 0x00007f1d390c14f4 in QApplication::notify () from /usr/lib64/qt4/libQtGui.so.4 #32 0x00007f1d3d14f07b in KApplication::notify () from /usr/lib64/libkdeui.so.5 #33 0x00007f1d39d742c8 in QCoreApplication::notifyInternal () from /usr/lib64/qt4/libQtCore.so.4 #34 0x00007f1d391118ac in ?? () from /usr/lib64/qt4/libQtGui.so.4 #35 0x00007f1d3913dbd2 in ?? () from /usr/lib64/qt4/libQtGui.so.4 #36 0x00007f1d3913fbfc in ?? () from /usr/lib64/qt4/libQtGui.so.4 #37 0x00007f1d3911d2bd in QApplication::x11ProcessEvent () from /usr/lib64/qt4/libQtGui.so.4 #38 0x00007f1d39140f45 in ?? () from /usr/lib64/qt4/libQtGui.so.4 #39 0x00007f1d39d73645 in QEventLoop::processEvents () from /usr/lib64/qt4/libQtCore.so.4 #40 0x00007f1d39d737a8 in QEventLoop::exec () from /usr/lib64/qt4/libQtCore.so.4 #41 0x00007f1d39d754ce in QCoreApplication::exec () from /usr/lib64/qt4/libQtCore.so.4 #42 0x00000000004034dd in main (argc=1, argv=0x7fff48da7cf8) at /var/tmp/portage/media-sound/amarok-9999/work/amarok-9999/src/main.cpp:128 reassigning to kdelibs, where this crash seems to occur. *** Bug 176186 has been marked as a duplicate of this bug. *** *** Bug 172336 has been marked as a duplicate of this bug. *** This is fixed with kdelibs-4.1.3 and 4.1.4, isn't it? Please reopen if not. @David: Sorry, definitely still present in 4.1.3. Can't comment on 4.1.4 yet. I've updated to kdelibs 4.1.3 (and amarok 2.0.1) and the bug is still present. I don't have the time to manually update to 4.1.4 and check against them, I'm just following fedora updates for now. And I can't compile amarok to re-test it, because it tries to link to libmysqld.a which isn't compiled with -fPIC. I'm told I need libmysqld.a from mysql-5.1 (which is not even in kubuntu intrepid), too much trouble. Now I'm running kde 4.1.4 and there are some differences: amarok no longer crashes, but the filter has now no effect at all, while still working correctly in Dolphin, if that matters. Does the filter work now (Amarok 2.1 beta released)? Please reassign back to kdelibs if you can reproduce a crash or a bug in kdelibs. Nope, the filter doesn't work at all currently (does nothing), but this could be a regression from my recent radical refactoring of the class. Have to look closer at this sometime to be sure. *** Bug 177981 has been marked as a duplicate of this bug. *** SVN commit 959203 by markey: Fix the filter widget in the Files browser. It turns out that the problem here was our custom MyDirLister class, which tried to filter out files that Amarok cannot play. Once upon a time (in 1.x) this class actually worked, but now it simply broke filtering, and for the life of me I can't figure out how it's supposed to work correctly. Finally I ended up removing the whole class. So the filtering works again now, but Amarok now also shows non-music files (.txt, etc). Whether that's a problem is debatable - I've heard some people saying that the suppression of certain file types was irritating anyway. BUG: 176139 M +1 -0 ChangeLog M +0 -1 src/CMakeLists.txt D src/browsers/filebrowser/MyDirLister.cpp D src/browsers/filebrowser/MyDirLister.h M +1 -3 src/browsers/filebrowser/MyDirOperator.cpp M +0 -2 src/browsers/filebrowser/MyDirOperator.h WebSVN link: http://websvn.kde.org/?view=rev&revision=959203 |