Bug 176086

Summary: Recursive slideshow only shows last album
Product: [Applications] digikam Reporter: Yann LE HIR <yann.lehir>
Component: Plugin-Generic-SlideShowAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 0.10.0   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In: 0.10.0
Sentry Crash Report:
Attachments: Patch file that solves the bug.
patch#2
patch

Description Yann LE HIR 2008-11-25 21:21:52 UTC 
Version:           SVN-888882 (using KDE 4.1.3)
Compiler:          cmake version 2.6-patch 2, gcc 4.1.2 (Gentoo 4.1.2 p1.0.2) 
OS:                Linux
Installed from:    Gentoo Packages

I was just hacking around trying to add a new slideshow system and I find out that asking digikam for a recursive slideshow only shows the last album.
Comment 1 Yann LE HIR 2008-11-25 21:23:45 UTC 
Created attachment 28821 [details]
Patch file that solves the bug.
Comment 2 Andi Clemens 2008-11-25 21:59:09 UTC 
There seem to be more problems. I have applied the patch (but with a foreach loop) and started the slideshow for a folder without subfolders.
Using All (F9) loads all images into the slideshow, but using "With Subfolders" does not load all images.
Same for a folder with subfolders. Recursive view mode displays more images then the slideshow loads.

Gilles, Marcel,

any idea?

Andi
Comment 3 Andi Clemens 2008-11-25 22:04:05 UTC 
Created attachment 28822 [details]
patch#2

slighty different patch (like in KDE3 branch)
Comment 4 Yann LE HIR 2008-11-25 22:46:17 UTC 
I didn't know of the second bug, which is actually completly independent from the first one.

I checked with a 16 images album, recursive mode and All mode works fine, but with a 2,000 images, the recursive mode only has 201 images.
I tried multiple times with different albums, always 201 images.

Same bug with latest digikam 0.9.5-svn

Some limits with ImageInfoJob ?
Comment 5 Yann LE HIR 2008-11-25 23:54:52 UTC 
Ok, I figured it out. Each time a slotItemsInfo is thrown, ImageInfoAlbumsJob changes of album, it should only change of album when signalCompleted is thrown.
Comment 6 Yann LE HIR 2008-11-25 23:56:06 UTC 
Created attachment 28827 [details]
patch
Comment 7 caulier.gilles 2008-12-03 16:49:03 UTC 
Andi,

yann has updated patch for you...

Gilles
Comment 8 Andi Clemens 2008-12-03 17:03:36 UTC 
Sounds fine, works fine... I will commit it.

Andi
Comment 9 Andi Clemens 2008-12-03 17:06:07 UTC 
SVN commit 892133 by aclemens:

patch by yann LE HIR: fix recursive slideshow

BUG:176086

 M  +1 -11     imageinfoalbumsjob.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=892133