| Summary: | Message sort order not remembered | ||
|---|---|---|---|
| Product: | [Unmaintained] kmail | Reporter: | Maxi Schimmel <maxi> |
| Component: | new message list | Assignee: | Szymon Stefanek <pragma> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | brendon, jan.mette, johann-nikolaus, jtamate, luke-jr+kdebugs, richard.bos, rolf.offermanns, wstephenson |
| Priority: | HI | Keywords: | triaged |
| Version: | 1.10.90 | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Maxi Schimmel
2008-11-20 11:57:08 UTC
This issue repeats inside a kmail session when I enter into another folder and come back to the previously ordered one, the order selection lost. You must have a more recent svn revision, in r886196 the tabs also dissapear from session to session. This is a known regression, we'll work on it to get it fixed before the 4.2.0 release. *** Bug 176886 has been marked as a duplicate of this bug. *** *** Bug 179559 has been marked as a duplicate of this bug. *** SVN commit 909096 by tmcguire: Remove the sort order settings from the aggregation, and make a stand-alone class instead, that can be saved per-folder or globally (the default). This should fix the problems with the message sort order not being remembered. Also, fix a little bug that the sort indicator of the headers would not always be shown. BUG: 175643 M +1 -0 CMakeLists.txt M +8 -166 messagelistview/core/aggregation.cpp M +2 -144 messagelistview/core/aggregation.h M +12 -109 messagelistview/core/aggregationeditor.cpp M +0 -10 messagelistview/core/aggregationeditor.h M +61 -79 messagelistview/core/manager.cpp M +5 -0 messagelistview/core/manager.h M +59 -52 messagelistview/core/model.cpp M +12 -0 messagelistview/core/model.h A messagelistview/core/sortorder.cpp [License: GPL (v2+)] A messagelistview/core/sortorder.h [License: GPL (v2+)] M +3 -3 messagelistview/core/theme.cpp M +4 -4 messagelistview/core/theme.h M +3 -3 messagelistview/core/themeeditor.cpp M +5 -24 messagelistview/core/view.cpp M +7 -0 messagelistview/core/view.h M +103 -55 messagelistview/core/widgetbase.cpp M +36 -6 messagelistview/core/widgetbase.h M +0 -3 messagelistview/pane.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=909096 *** Bug 180112 has been marked as a duplicate of this bug. *** *** Bug 180444 has been marked as a duplicate of this bug. *** *** Bug 180710 has been marked as a duplicate of this bug. *** Problem is still present on kde-4.1.96 (kde-4.2rc1) > Problem is still present on kde-4.1.96 (kde-4.2rc1)
Yes, not yet backported.
> Yes, not yet backported.
Oh, please do before kde-4.2 is officially released. It's really (ahum)
annoying to have to change the sorting order for each and every visited
folder. kde-4.2 will be a better place, if the code is backported :)
SVN commit 913714 by tmcguire: Backport the sort order fixes. I reverted all string changes, those are not very visible strings anyway. Sorry for the very very late commit, I hope I didn't break anything and apologize in advance. === Backport r909096 by tmcguire from trunk to the 4.2 branch: Remove the sort order settings from the aggregation, and make a stand-alone class instead, that can be saved per-folder or globally (the default). This should fix the problems with the message sort order not being remembered. Also, fix a little bug that the sort indicator of the headers would not always be shown. CCBUG: 175643 === Backport r913236 by tmcguire from trunk to the 4.2 branch: Since I decoupled the sort order from the aggregations, there were some combinations that didn't made sense, for example grouping by date by sorting by something different. Fix this situation by not allowing those combinations, and using sensible defaults instead. === Backport r913240 by tmcguire from trunk to the 4.2 branch: Slightly better way to detect incorrect sort orders, as we now know the default value. ==== Backport r913666 by tmcguire from trunk to the 4.2 branch: Fix crash. M +1 -0 CMakeLists.txt M +8 -166 messagelistview/core/aggregation.cpp M +2 -144 messagelistview/core/aggregation.h M +11 -108 messagelistview/core/aggregationeditor.cpp M +0 -10 messagelistview/core/aggregationeditor.h M +49 -60 messagelistview/core/manager.cpp M +5 -0 messagelistview/core/manager.h M +57 -50 messagelistview/core/model.cpp M +12 -0 messagelistview/core/model.h A messagelistview/core/sortorder.cpp trunk/KDE/kdepim/kmail/messagelistview/core/sortorder.cpp#909096 [License: GPL (v2+)] A messagelistview/core/sortorder.h trunk/KDE/kdepim/kmail/messagelistview/core/sortorder.h#909096 [License: GPL (v2+)] M +3 -3 messagelistview/core/theme.cpp M +4 -4 messagelistview/core/theme.h M +3 -3 messagelistview/core/themeeditor.cpp M +5 -24 messagelistview/core/view.cpp M +7 -0 messagelistview/core/view.h M +113 -58 messagelistview/core/widgetbase.cpp M +36 -6 messagelistview/core/widgetbase.h M +0 -3 messagelistview/pane.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=913714 |