| Summary: | setting panels of imageeditor effects should be fully visible | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | simon |
| Component: | ImageEditor-Plugins | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | caulier.gilles, gsking1, marcel.wiesweg, sven.burmeister |
| Priority: | NOR | ||
| Version: | 0.10.0 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 7.5.0 | |
| Sentry Crash Report: | |||
|
Description
simon
2008-11-20 02:04:21 UTC
Confirming for 0.10b7svn and 0.9.5svn. It is really awkward. In the first moment I always think something is wrong because some info isn't visible. Several possible solution: 1) redesing settings to accomodate in default minimum width of right panel 2) increase minimum width of right panel to accomodate all settings panels 3) automatically adjust width of right panel to make everything visible Marcel, This problem come from of QScrollView (QScrollArea) used to display sidebar contents to be compatible with small screen size as with EEEPC. The problem is how to get the right widget size hosted by scroll view. It's never right here... Andi, We need to optimize also the design on the bottom of settings view. Perhaps some buttons text can be removed to optimize space, and let's only icons alone on buttons... Gilles Caulier hi, imho "small screen size as with EEEP" are definetely not the main target a image managing software should be optimized for. i vote for option 3) outlined in comment #1; a option could switch if the scrollbars should be used or not (small size displays) This is not only for EEEPC. Problem appears with 19/9 laptop screen (like mine) where digiKam window become behing KDE task bar. Gilles Caulier We should change the hardware specs: Linux 2.6.xx + widescreen beamer :-) About design - quick review of plugins: Method: resized 0.9.5svn IE window to 800x600 (including window decoration); set right panel width to minimum size where Caption/Tags panel fit (the widest default panel - small surprise, always thought Colors is due to histogram). Looks like *all* plugins are resizing dialog to 830-840px PLUS they don't allow to resize window below this width - so for practical reasons test is for 840px width - which is already 40px too much. Notes below are not bugs per se but things where some pixels of width can be gained, "OK" means only plugin fits withou horizontal scrollbar: Auto-Correction: OK B/C/G: OK H/S/L: OK Color correction: value fields are too wide B&W: just few pixels, value field too wide? in this width mess with buttons Color management: OK Levels: value fields too wide? broken vertical scrolling - one histogram stays in place while the rest is moving Color Effects: OK White Balance: sliders could be more compressed - due to precise nature of corrections they are already almost unusable - get rid of them? Curves: OK Channel mixer: OK Sharpen: OK Blur: OK Red eye: OK Inpainting: sliders, value fields too wide Noise reducton: sliders, value fields too wide Hot pixels: OK Lens distortion: sliders, value fields too wide Restoration: sliders, value fields too wide Vignetting: OK - due to <br> between label and slider - solution everywhere? Aspect ratio crop: too much everything Shear: sliders, fields, even <br> doesn't help Free rotation: as in Shear Perspective: OK Texture: OK Border: OK Text: narrower font Size column and text alignment buttons Template superimpose: not OK, no idea how help Raindrops, Infra red, Oil paint, Emboss, Film grain, Blur effects, Charcoal: OK Distorition: sliders, value fields too wide General notes: a) in many UIs width was broken due to adding of reset button without adjusting the rest of the dialog HTH I didn't see this comment before. Looks like what I just reported here: http://bugs.kde.org/show_bug.cgi?id=178291 *** Bug 178291 has been marked as a duplicate of this bug. *** Marcel, Are you see my comment #2 ? Gilles SVN commit 900430 by mwiesweg: Reimplement minimumSizeHint of the scroll area. The minimumSizeHint of a QScrollArea is usually independent of the widget contained, but here we want to have a certain amount of minimum horizontal space. Limit minimum size to 40% of desktop width. CCBUG: 175630 M +23 -9 editortoolsettings.cpp M +2 -0 editortoolsettings.h WebSVN link: http://websvn.kde.org/?view=rev&revision=900430 With this commit the sidebar is automatically extended to the needed size in the horizontal direction, vertical is untouched. We can limit the required space according to desktop size (currently it's 40% of desktop width). It also seems to behave quite well when resizing the window. Please test, if you find no problems we can mark this as fixed. Marcel, Your patch work fine here. Great... Note: your patch need to be backported to KDE3 branch because the same implementation is used with scroll view container in editor tool settings page. Gilles Caulier Looks good to me. Problem solved. *** Bug 178190 has been marked as a duplicate of this bug. *** Marcel, Are you see my comment #12 ? KDE3 still not patched yet ? Gilles Caulier SVN commit 904225 by mwiesweg: Backport commit 900430 to KDE3: Reimplement minimumSizeHint of the scroll area. The minimumSizeHint of a QScrollView is usually independent of the widget contained, but here we want to have a certain amount of minimum horizontal space. Limit minimum size to 40% of desktop width. CCBUG: 175630 M +22 -7 editortoolsettings.cpp M +2 -0 editortoolsettings.h WebSVN link: http://websvn.kde.org/?view=rev&revision=904225 Thanks MArcel, it work fine here... Gilles |