| Summary: | counter stops with a wrong displayed total amount | ||
|---|---|---|---|
| Product: | [Applications] lskat | Reporter: | Uwe Bugla <uwe.bugla> |
| Component: | general | Assignee: | martin |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | newton.moura.junior, uwe.bugla, walch.martin |
| Priority: | NOR | ||
| Version First Reported In: | 1.40 | ||
| Target Milestone: | --- | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/games/lskat/commit/563245095e4bc06ac647cc14db1addbd67cb8b9d | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: |
screenshot from 4.14.0
screenshot of a game won with 90 or more points (but not to nil) screenshot of a game won to nil new screenshot of a game won with 90 or more points (but not to nil) |
||
The platform where the bug appears is not "Debian testing", but it is a mixture of Debian Lenny, Sid, and Experimental instead. So please overwork your standard bug report formulas - they're incomplete. *** Bug 300474 has been marked as a duplicate of this bug. *** Created attachment 88361 [details] screenshot from 4.14.0 (In reply to Uwe Bugla from comment #0) > Playing lskat one player can reach 120 points as maximum (at least > theoretically). > However the counter seems to stop at 90 points. This is actually intended behaviour. The message is a bit misleading: the meaning is that that player has won with 90 points or even more and thus the player's score is increased by three and not only by two (like for a won game with less than 90 points). I guess the text message should be clarified accordingly. > I have finished several games with a total score of 104 points. > It shows numerically correct the 104 points, but it shows them like this: 10 > 4 This problem has already been described in bug #167936 and although that bug report is marked as RESOLVED/FIXED, this should be revisited as I can still reproduce it. The screenshot shows that the translated message does not fit on the screen. Dear Bug Submitter, This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond. Thank you for helping us make KDE software even better for everyone! Dear Bug Submitter, This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? This bug will be moved back to REPORTED Status for manual review later, which may take a while. If you are able to, please lend us a hand. Thank you for helping us make KDE software even better for everyone! Created attachment 116632 [details]
screenshot of a game won with 90 or more points (but not to nil)
Current state on lskat 1.50 from KDE Applications 18.04.3
Created attachment 116633 [details]
screenshot of a game won to nil
Current state on lskat 1.50 from KDE Applications 18.04.3
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version? If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you! Created attachment 155545 [details]
new screenshot of a game won with 90 or more points (but not to nil)
Yes, still there.
This seems to be theme-specific. At least for me it looks fine with "Egyptian" and "Green Blase". The line wrap only happens with "Oxygen". A possibly relevant merge request was started @ https://invent.kde.org/games/lskat/-/merge_requests/11 Git commit 563245095e4bc06ac647cc14db1addbd67cb8b9d by Albert Astals Cid, on behalf of Martin Walch. Committed on 16/04/2023 at 09:39. Pushed by aacid into branch 'master'. Fix line wraps in point counters and player names Split fontWidthUpper into fontWidthName and fontWidthPoints. Set new values for posName, posPoints, fontWidthName, fontWidthPoints: * avoid line breaks in the point counters with the Oxygen theme * wrap player names before they reach their field bounds * give player names enough room for a second line Also clean up spelling and whitespace in the rc files. See also: #167936, #300474 M +41 -42 grafix/blue.rc M +39 -40 grafix/egyptian.rc M +39 -40 grafix/oxygen.rc M +6 -4 src/scoresprite.cpp https://invent.kde.org/games/lskat/commit/563245095e4bc06ac647cc14db1addbd67cb8b9d |
Version: 1.40 (using KDE 4.1.3) Compiler: gcc 4.3 OS: Linux Installed from: Debian testing/unstable Packages Playing lskat one player can reach 120 points as maximum (at least theoretically). However the counter seems to stop at 90 points. Example to make the bug visible: I have finished several games with a total score of 104 points. It shows numerically correct the 104 points, but it shows them like this: 10 4 Not like that: 104 Parallely the following dumb message appears: .... has won the game with 90 points. Super! It should be 104 in both cases, shouldn't it? Can you please fix those 2 bugs in one? Thanks Uwe