Summary: | Flickr import tool wishlist [patch] | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Daniel Welch <danielwelch> |
Component: | Plugin-WebService-Flickr | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | REOPENED --- | ||
Severity: | wishlist | CC: | adam, anselmolsm, brauliobo, caulier.gilles, dinhthanhtrung1996, kr.vikas, matti-kdebugs, metzpinguin, rap, vardhman |
Priority: | NOR | ||
Version: | 6.0.0 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: | |||
Attachments: | listPhotos method |
Description
Daniel Welch
2008-11-16 20:52:55 UTC
I am think of providing this feature in basic form very soon. i would like this feature too. can help in testing and would like to code it. please give some directions. Created attachment 40601 [details]
listPhotos method
(This patch was submitted to the mailing list, I'm posting it here following recommendations)
I'm also interested in an import feature for flickr plugin. The attached patch is an initial implementation of the listPhotos method that retrieves from the Flickr API the list of pictures in a given set. In this list, we receive some parameters needed in order to find the URL to each picture. It's just a first step, there are more work needed. I have a svn account, but as it's my first contribution to kipi-plugins, I believe the right thing to do is to ask a first review of other kipi-plugins developers.
Hi Anselmo, Thanks for sending the patch, unfortunately I am not contributing actively to the project and many other authors would be much more prompt and helpful with the patching in. Please add/cc Caulier Gilles (Digikam project lead) to this bug and he will make sure the right people get added. Thanks, Vardhman On Mon, Feb 8, 2010 at 3:00 AM, Anselmo Lacerda Silveira de Melo < anselmo.melo@openbossa.org> wrote: > https://bugs.kde.org/show_bug.cgi?id=175327 > > > Anselmo Lacerda Silveira de Melo (anselmolsm) <anselmo.melo@openbossa.org> > changed: > > What |Removed |Added > > ---------------------------------------------------------------------------- > Status|UNCONFIRMED |NEW > AssignedTo|vardhman@gmail.com |anselmo.melo@openbossa.org > Ever Confirmed|0 |1 > > > > > --- Comment #3 from Anselmo Lacerda Silveira de Melo (anselmolsm) <anselmo > melo openbossa org> 2010-02-08 12:00:39 --- > Created an attachment (id=40601) > --> (http://bugs.kde.org/attachment.cgi?id=40601) > listPhotos method > > (This patch was submitted to the mailing list, I'm posting it here > following > recommendations) > > I'm also interested in an import feature for flickr plugin. The attached > patch > is an initial implementation of the listPhotos method that retrieves from > the > Flickr API the list of pictures in a given set. In this list, we receive > some > parameters needed in order to find the URL to each picture. It's just a > first > step, there are more work needed. I have a svn account, but as it's my > first > contribution to kipi-plugins, I believe the right thing to do is to ask a > first > review of other kipi-plugins developers. > > -- > Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are on the CC list for the bug. > You are the assignee for the bug. > Vardhman, I'm already there. No need to CC me (:=))) Gilles There is some functional code at https://code.launchpad.net/~brauliobo/kflickr/kflickr2 for viewing albums and downloading their photos, integrated poorly into the user interface. *** Bug 137892 has been marked as a duplicate of this bug. *** (In reply to comment #6) > There is some functional code at > https://code.launchpad.net/~brauliobo/kflickr/kflickr2 for viewing albums and > downloading their photos, integrated poorly into the user interface. Cool! thanks =) When are we going to see this feature? Thanks, Vikas. Vardhman, We need to take a look about his patch at next coding sprint in France Gilles Caulier Really interested in this feature. Seems forgoten. Need help with development or testing? (In reply to comment #11) > Really interested in this feature. Seems forgoten. Need help with development > or testing? Great! I wrote more code than the attached patch, but it's not ready (I was able to download pictures, though). I can send this WIP code for you. I can try to help in the development, the main problem is that I'm currently in a time consuming project in my job =/ Please attach a patch against git master to this bugzilla entry. Thanks in advance Gilles Caulier Anselmo, Do you see my comment #13 ? Gilles Caulier What the status of this entry ? There is no more patch to review here ? Gilles Caulier New Kipiplugins 4.11.0 is available : https://www.digikam.org/node/740 Can you reproduce the problem with this release ? Gilles Caulier Maik, Sound like this feature is already implemented. Right ? Gilles digiKam + kipiplugins 5.6.0 is just released. https://www.digikam.org/news/2017-06-21-5.6.0-release-announcement/ This file still valid with this version ? Gilles Caulier What's about this file using last 5.8.0 pre-release bundle available here : https://files.kde.org/digikam/ Gilles Caulier Thanh, What's about this file where we have an older patch here ? It still suitable for 6.0.0 ? Gilles Caulier Thanh, For this entry, and following your recent work for GSoC 2018, we have 2 choices : 1/ Review the patch and re-use some part to integrate few ideas in current code. 2/ Ignore this patch contents, if the ideas are far than new improvements done with your project. We need to set the future way for this entry. I vote for 2/ as all the export tools dialog step by step more and less factored and unified (thanks again to Thanh for this hard work). Maik, your viewpoint ? Gilles In my point of view, option 1 is better. It's true that our plan is uniting all web services to the new common wizard, and Flickr import will not be an exception. However, the core codes for import is method listPhotos(), which was written and tested (I think) by Anselmo. Since that method has API call inside (which is specific for each service as you already know), it will remain unchanged when we integrate Flickr import to the new wizard in the future. Moreover, the old patch posted here is for listPhotos(), so reviewing it in order to reuse and adapt it to new wizard will save time. Best, Thanh Thanks for this clarification Thanh Gilles Please test with 6.2.0 pre-release bundles available here : https://files.kde.org/digikam/ Thanks in advance Gilles Caulier |