Bug 173901

Summary: digikam contains a convience copy of cimg code
Product: [Applications] digikam Reporter: Mark Purcell <msp>
Component: Plugin-Editor-RestorationAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED INTENTIONAL    
Severity: wishlist CC: caulier.gilles
Priority: NOR    
Version: 0.9.4   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In: 1.9.0
Sentry Crash Report:

Description Mark Purcell 2008-10-30 14:30:12 UTC 
Version:           0.9.4 (using 3.5.10, Debian Package 4:3.5.10.dfsg.1-1 (lenny/sid))
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.26-1-686

As has been done with the sqlite3 library it would be good for digikam during build to check and see if there is a system installed cimg library of the correct version and build/ link against that, rather than the internal copy of that lib.

By doing this system resources are saved by linking to shared libs and security issues/ bugs in libs only need to be fixed in one location rather than all the applications which may or may not embed copies.

Of course this does make version control an issue, however as demonstrated by sqlite3 it is workable.

http://bugs.kde.org/show_bug.cgi?id=160966#c65

Mark

----------  Forwarded Message  ----------

Subject: Bug#484777: digikam contains a convience copy of cimg code
Date: Friday 06 June 2008
From: Mark Purcell <msp@debian.org>
To: Debian Bug Tracking System <submit@bugs.debian.org>

Package: digikam
Version: 2:0.9.4~beta5-1
Severity: wishlist

Debian policy 3.8.0.0 states:

  * Debian packages should not use convience copies of code from other
    packages unless the included package is explicitly intended to be
    used that way.                                            [4.13]

digikam does this with cimg (version 1.2.8).
Comment 1 caulier.gilles 2008-10-30 14:36:00 UTC 
Yes, this can be done easily. it's already in my TODO list

Gilles
Comment 2 Andi Clemens 2009-07-02 22:22:07 UTC 
Gilles,

what about this one?
Comment 3 caulier.gilles 2009-07-02 22:27:25 UTC 
no more. A cmake script must be written to detect CImg from computer.

Gilles
Comment 4 caulier.gilles 2011-02-03 09:22:28 UTC 
This entry cannot be fixed. Since CImg 1.2.0, all Greystoration code have been migrated to GMic library which is completly different and need huge change in Greystoration interface from digiKam core.

So, compatibilty with CImg > 1.2.0 is not preserved, which is a shame from a shared library.

CImg source code < 1.2.0 will still under digiKam core until Greystoration interface will be ported to GMic.

Gilles Caulier