| Summary: | kontact wont start after intrepid update, had problem with adding contacts before update | ||
|---|---|---|---|
| Product: | [Unmaintained] kdelibs | Reporter: | Kevin <raccoonstrait> |
| Component: | kded | Assignee: | Flavio Castelli <flavio> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | crash | CC: | faure |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Kevin
2008-10-27 19:47:12 UTC
Reassigning to someone who knows KDirWatch. (Flavio: how about using flavio@castelli.name in kde-common/accounts? ;-) SVN commit 1058169 by cfeck:
Fix broken reading in inotifyEventReceived
Multiple bugs:
* MAX_PATH is 4096 on linux, but inotify_event needs some bytes as well
* the "pending" variable was incorrectly abused to mean both pending
bytes in buffer as well as pending bytes in stream
* the offset was not reset to zero when the next chunk was reading
* when an event was larger than what was available in buffer, it was reading
beyond the buffer boundaries
Many thanks to David for review and help with improving clarity of the code.
David, please test for regressions, maybe add a test which changes
some 1000 files in one go.
CCMAIL:faure@kde.org
CCBUG:165548
CCBUG:173696
CCBUG:175005
CCBUG:198692
CCBUG:204178
M +20 -9 kdirwatch.cpp
WebSVN link: http://websvn.kde.org/?view=rev&revision=1058169
*** This bug has been marked as a duplicate of bug 165548 *** |