Summary: | Others group is not sorted | ||
---|---|---|---|
Product: | [Applications] dolphin | Reporter: | heikki.lehvaslaiho |
Component: | general | Assignee: | Peter Penz <peter.penz19> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | andresbajotierra, ereslibre, frank78ac, m.debruijne, stephend |
Priority: | NOR | ||
Version: | 16.12.2 | ||
Target Milestone: | --- | ||
Platform: | unspecified | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
Wrong alphabetic sorting inside the group "Others" (trunk)
Almost a correct fix |
Description
heikki.lehvaslaiho
2008-10-17 13:05:33 UTC
Thanks for the bug report. I can confirm this in 4.1.2 (Kubuntu) and trunk rev. 873100. I can reproduce this bug using: Qt: 4.4.3 KDE: 4.1.85 (KDE 4.1.85 (KDE 4.2 Beta2)) kdelibs svn rev. 899058 / kdebase svn rev. 899058 on ArchLinux x86_64 - Kernel 2.6.27.8 A workaround is: Re-sort by size (icons aren't grouped) and then Re-sort by Name again Now the files in the Other group are ordered. SVN commit 899245 by ppenz: Assure that the items within the "Others" group are sorted too, when sorting by name and using categorization. @Rafael: Could you please have a look whether this patch is OK? It fixes bug 173027 but it is unclear for me why the deleted lines had been added at all. Thanks :-) CCMAIL: ereslibre@kde.org BUG: 173027 M +0 -4 dolphinmodel.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=899245 SVN commit 900071 by ppenz: revert SVN commit 899245: The patch does not work as expected. CCMAIL: ereslibre@kde.org CCBUG: 173027 M +4 -0 dolphinmodel.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=900071 I had to reopen this issue again, as the patch does not work as expected :-( *** Bug 188622 has been marked as a duplicate of this bug. *** This is fixed in trunk (KDE 4.4). Please reopen if you can still reproduce this issue in trunk. Since the fix has been a complete rewrite of KCategorizedView (from what I understand), this cannot be backported to KDE 4.3.x series. (In reply to comment #7) > This is fixed in trunk (KDE 4.4). Please reopen if you can still reproduce this > issue in trunk. > > Since the fix has been a complete rewrite of KCategorizedView (from what I > understand), this cannot be backported to KDE 4.3.x series. ---- Thanks a lot! I will test the new version and report if I'm still able to reproduce this. @Rafael: The issue is still there on trunk :-( I've attached a screenshot... The screenshot shows: - (x) Sort by Name - [x] Folders First - [x] Show in Groups I know from my patches at comment 3 that the fix is non-trivial, but I'll give it a try again. Created attachment 36158 [details]
Wrong alphabetic sorting inside the group "Others" (trunk)
Ok, now I could reproduce it. So it seems that KCategorizedSortFilterProxyModel (kdeui/itemviews) on lessThan method is returning before asking subSortLessThan(). Still investigating... Created attachment 36159 [details]
Almost a correct fix
Fixes this bug but introduces another one.
For example, a file starting with "Ñ" or "ñ" is not placed between "M" and "N", where it belongs, but between "Z" and "Others".
SVN commit 1011495 by ppenz: - Fixed issue that the items inside the "Other" category are sorted in a wrong manner. - Removed redundant code. BUG: 173027 M +2 -6 dolphinmodel.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1011495 SVN commit 1011496 by ppenz: Backport of SVN commit 1011495: - Fixed issue that the items inside the "Other" category are sorted in a wrong manner. - Removed redundant code. CCBUG: 173027 M +2 -6 dolphinmodel.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1011496 I am not sure this fix is the correct... I think there are characters over 'Z', so it doesn't actually matter if the second is the "ReplacementCharacter", because the first one (Z) is not the highest one... I am writing another patch... and you can have a look... Anyway, tested your fix and works here. Mine was getting more complicated. Hoping yours is completely fine, but not sure about it... Thanks Rafael! I tried several approaches and for me it is unclear in general how the sortRoleData() can influence the sort order of items _within_ a group... (I did not investigate in detail the KCategorized* classes) E. g. when using '[' instead of 'Z' (where '[' has a unicode of Z + 1) the sorting within the group is wrong again. When using 'Z' the sorting is OK, but then there is a conflict with the Z-group... |