Bug 172912

Summary: "Slide" becomes "Slideshow" text on button in Main window. One-line change
Product: [Applications] digikam Reporter: Joe Biden <mailinglist>
Component: Plugin-Generic-SlideShowAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: caulier.gilles
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Unspecified   
Latest Commit: Version Fixed In: 0.10.0
Sentry Crash Report:

Description Joe Biden 2008-10-16 04:15:40 UTC
Version:            (using Devel)
Installed from:    Compiled sources

My patch cotains other unmerged changes, so I'll paste in the tiny relevant section. It's just the addition of 4 letters to a button text.


@@ -877,7 +877,7 @@                                                                                            
                                                                                                               
     // -----------------------------------------------------------                                            
                                                                                                               
-    d->slideShowAction = new KActionMenu(KIcon("view-presentation"), i18n("Slide"), this);                    
+    d->slideShowAction = new KActionMenu(KIcon("view-presentation"), i18n("Slideshow"), this);                
     d->slideShowAction->setDelayed(false);                                                                    
     actionCollection()->addAction("slideshow", d->slideShowAction);
Comment 1 Joe Biden 2008-10-16 04:16:30 UTC
File changed is digikam/digikamapp.cpp
Comment 2 Andi Clemens 2008-10-16 10:25:53 UTC
Right, I think this is better. Never seen this before since I use only icons in the toolbar without text.
I will commit this immediately.

Andi
Comment 3 Andi Clemens 2008-10-16 10:30:47 UTC
SVN commit 871988 by aclemens:

use 'Slideshow' for the tool-button's text, it is more clear for users.

BUG:172912

 M  +2 -1      NEWS  
 M  +1 -1      digikam/digikamapp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=871988
Comment 4 caulier.gilles 2008-10-16 11:10:21 UTC
NOTE: i have set "Slide" in the pass to reduce text size under icons (default mode in KDE4), else tool bar become larger.

The same issue is done in other tool bar button...

Gilles Caulier
Comment 5 Andi Clemens 2008-10-16 11:25:53 UTC
Oh so this change was wrong? But "Full Screen" button isn't smaller, too...


Andi
Comment 6 caulier.gilles 2008-10-16 11:31:10 UTC
Andi,

If "SlideShow" is better than "Slide", it's fine for me... I'm not a good English speaker (:=)))

I justify the reason why "Slide" words is used here.

And yes "Full Screen" is long... But i have already fixed that: before this string been "Full Screen Mode"...

Gilles
Comment 7 Andi Clemens 2008-10-16 11:47:06 UTC
:-)
Yes Full Screen Mode is long.

I'm done with Brendan's patches so far, the welcome page is something I'm not happy with now (due to the use of nested lists), but we can decide what to do.
I'll create a patch with hunks I'm unsure about and post it on ML.

Andi