Bug 172719

Summary:	cannot configure with cmake-options
Product:	[Developer tools] kdesrc-build	Reporter:	Andreas Pakulat <apaku>
Component:	general	Assignee:	Michael Pyne <mpyne>
Status:	RESOLVED FIXED
Severity:	grave
Priority:	NOR
Version:	1.7
Target Milestone:	---
Platform:	Unlisted Binaries
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	.kdesvn-buildrc producing the problem

Description Andreas Pakulat 2008-10-13 14:30:58 UTC

As soon as I set any cmake-options on a module kdesvn-build fails to configure the module. It executes cmake without the actual source directory in the arguments as far as I can see from the output.

Reverting r867894 fixes the problem. The comment on the commit also seems strange, at least here cmake-options that have quotes are not a problem without that revision.

Comment 1 Michael Pyne 2009-01-12 04:09:19 UTC

I have someone else with the same bug but I can't reproduce it myself.

Can you attach the kdesvn-buildrc you're using?

Comment 2 Andreas Pakulat 2009-01-12 07:24:37 UTC

Created attachment 30165 [details]
.kdesvn-buildrc producing the problem

Comment 3 Michael Pyne 2009-01-13 00:46:00 UTC

I'm so stupid, I never tried having tons of cmake-options in a single module when trying to reproduce.

I've reproduced the problem, now to isolate the cause.

Comment 4 Michael Pyne 2009-01-13 01:05:40 UTC

SVN commit 910294 by mpyne:

Fix bug 172719 (cmake-options causes kdesvn-build to fail).

The root cause of the problem was that when you had more than one option on a single cmake-options
command that it was not getting split into a list properly.

The root cause of *that* error was that the regular expression I used to perform the split
(without splitting around double-quotes) failed with leading whitespace.  I didn't do testing for
that case but that it how the function ends up getting called in kdesvn-build.

In addition to the bug I've added quotes around individual command parameters for log_command() to
make future instances of this type of bug (improper splitting) more obvious.

BUG:172719


 M  +3 -2      kdesvn-build  


WebSVN link: http://websvn.kde.org/?view=rev&revision=910294

Comment 5 Michael Pyne 2009-01-15 02:36:10 UTC

SVN commit 911197 by mpyne:

Backport fix for bug 172719 to KDE 4.2 branch as requested by André Wöbbeking.

Please note however that the next release of kdesvn-build will be from /trunk
so this is only useful if you're tracking 4.2 kdesdk for your kdesvn-build.

CCBUG:172719


 M  +2 -1      kdesvn-build  


WebSVN link: http://websvn.kde.org/?view=rev&revision=911197