Summary: | Cannot edit the bookmark address of a kate "yellow star" bookmark | ||
---|---|---|---|
Product: | [Applications] kate | Reporter: | tjabo kloppenburg <tjabo.kloppenburg> |
Component: | general | Assignee: | Daniel Teske <teske> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kdedevel, martin.hohenberg, mchugh19, uwolfer |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Attachments: |
Line edits in the bookmark dialog are messed up.
Candidate patch for this issue. |
Description
tjabo kloppenburg
2008-10-12 11:49:43 UTC
I can't reproduce the "DEL" behaviour using trunk - I suspect it is related to http://bugs.kde.org/show_bug.cgi?id=167637, which is fixed. The inability to type "//" is there and this aspect is a dupe of https://bugs.kde.org/show_bug.cgi?id=171193. In general, the KLineEdits in the dialog behave very oddly - for example, the "clear" button appears roughly a 1/4 of the way in to the text field (I'll attach a screenshot in a sec). Assigning to Daniel, as I think he created the dialog class (this has nothing to do with Kate/ KWrite). Created attachment 28260 [details]
Line edits in the bookmark dialog are messed up.
The KLineEdits have the "clear" button in the wrong place (except for the Search box).
*** Bug 171193 has been marked as a duplicate of this bug. *** "I cannot enter two slashes as need for every remote protocol" This is because KUrl url("http://"); QString urlAsString = url.pathOrUrl(); gives urlAsString as "http:" (note the missing "//"), and the logic in BookmarkInfoWidget::showBookmark(...) will overwrite the text you have typed with this string. I investigated a means to work around this precise situation and it worked, but then I ran into an additional problem: attempting to type the "." after http://kde wouldn't work :/ So I changed tack: what we really want to do is update the text box when the URL it represents does not match that of the bookmark, hence the patch below. I've not found any regressions caused by this patch, but it would be nice if people could test thoroughly :) Created attachment 29676 [details]
Candidate patch for this issue.
CC'ing uwolfer, as it looks like I might be trampling all over his code ;) SVN commit 902291 by aseigo: call updateClearButton in setReadOnly(false) instead of having some (buggy) clear icon management code in setReadOnly CCBUG:172647 M +9 -17 klineedit.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=902291 Simon, I think you patch looks good. SVN commit 902594 by sstjames: Update the text in the Location KLineEdit only when the actual URL it represents conflicts with that of the current bookmark, not when the textual representations of the URLs differ. BUG:172647 M +12 -5 bookmarkinfo.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=902594 *** Bug 179061 has been marked as a duplicate of this bug. *** |