| Summary: | [BiDi/Unicode] Cursor direction dependent upon last letter typed, not selected keyboard layout | ||
|---|---|---|---|
| Product: | [Applications] kate | Reporter: | Dotan Cohen <kde-2011.08> |
| Component: | kwrite | Assignee: | KWrite Developers <kwrite-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | christoph, elcuco, justin.zobel, kde-2011.08, zayed.alsaidi |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Unspecified | ||
| Latest Commit: | https://invent.kde.org/frameworks/ktexteditor/commit/9a07647ee120da5b046cc71186590decebc8ded9 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Dotan Cohen
2008-10-12 02:33:30 UTC
Confirmed in KDE 4.2 Is that still the case? Yes, this is still the case on Kate Version 3.6.5 Using KDE Development Platform 4.6.5 Seems we have serious problems with this, anybody could help out with some patch? *** This bug has been marked as a duplicate of bug 165397 *** Thank you Christoph. This is not a dupe of bug 165397. That bug concerns the direction that the cursor moves when pressing the arrow buttons. This bug concerns the appearance of the cursor. I just confirmed that this bug is still present in KDE 4.9. Considering some of the other RTL issues this is pretty minor so I'm marking it as such. Dotan, I would like close this bug as wont-fix. I think that the feature will be implemented not depending on the KB layout, but on the paragraph content. I am not convinced that what you describe is correct (show me another application/OS that does this to test and see by myself). See also (I am working on that bug right now): https://bugs.kde.org/show_bug.cgi?id=165397 Diego: most applications (such as Firefox) don't show a different cursor for each language direction. In fact, I would have no problem with that being the case, if Kate were to show the same cursor for each language. But the current implementation in which the wrong cursor is shown is in fact a problem. I do know that the Mac applications does show a different cursor for RTL and LTR, but I'm not sure about Windows applications and other MS software. LibreOffice does show the different cursors per language directionality, but it is even buggier than Kate's! I suggest to "won't fix" this bug by just showing the same cursor in Kate. Even other KDE applications, such as Konqueror's address bar, show the same cursor per language directionality. Diego, any further comments on this? For my understanding, the kate should capture the event of changing the keyboard layout then change the cursor maintaining the focus during this process. While this is a good future, I do not see a great benefit from it. The only application (to my knowledge) has this future is Firefox but it takes around 3 sec to change the cursor!! The current implementation of kate (I'm using KDE 4.10.4) will change the cursor to correct one after entering a new letter. This behavior is same as other Qt applications and libreoffice. Is that now ok the way it is or not? ;) @Christoph: No, the situation today is exactly as it was in the OP. Dotan can you please confirm if this is still an issue in Kate from KDE5. Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! @Justin Zobel: No, the situation today is exactly as it was in the OP. @Justin Zobel: No, the situation today is exactly as it was in the OP. A possibly relevant merge request was started @ https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/532 Git commit 5934689df192aa681c6d7856bd6eaed9f22790a5 by Christoph Cullmann, on behalf of Waqar Ahmed. Committed on 29/03/2023 at 18:10. Pushed by cullmann into branch 'master'. Draw caret ourselves Drawing caret ourselves helps solve a few issues: 1. With custom line height, the caret is no longer smaller than line 2. Cursor direction depends on the block content, not keyboard layout (bug 172630). Our own cursor will not draw the direction marker and thus will avoid this issue 3. Make cursor insertion point a few pixels larger vertically (bug 452853). You can just increase the line height and the caret will be bigger :) Technically, this is not exactly what is requested, but it works. Making Cursor visually larger than the line is _possible_ but it means that now we need to _always_ dirty 3 lines for repaint: current line, line above, line below which is a lot of uneeded work for such a small thing. So this will do. It is also more efficient than the Qt implementation as the work done in here is a lot less. Related: bug 452853 M +24 -1 src/render/katerenderer.cpp https://invent.kde.org/frameworks/ktexteditor/commit/5934689df192aa681c6d7856bd6eaed9f22790a5 (In reply to Christoph Cullmann from comment #18) > Git commit 5934689df192aa681c6d7856bd6eaed9f22790a5 by Christoph Cullmann, > on behalf of Waqar Ahmed. Thank you, I look forward to testing this. Git commit 9a07647ee120da5b046cc71186590decebc8ded9 by Waqar Ahmed. Committed on 04/04/2023 at 18:59. Pushed by cullmann into branch 'kf5'. Draw caret ourselves Drawing caret ourselves helps solve a few issues: 1. With custom line height, the caret is no longer smaller than line 2. Cursor direction depends on the block content, not keyboard layout (bug 172630). Our own cursor will not draw the direction marker and thus will avoid this issue 3. Make cursor insertion point a few pixels larger vertically (bug 452853). You can just increase the line height and the caret will be bigger :) Technically, this is not exactly what is requested, but it works. Making Cursor visually larger than the line is _possible_ but it means that now we need to _always_ dirty 3 lines for repaint: current line, line above, line below which is a lot of uneeded work for such a small thing. So this will do. It is also more efficient than the Qt implementation as the work done in here is a lot less. Related: bug 452853 M +24 -1 src/render/katerenderer.cpp https://invent.kde.org/frameworks/ktexteditor/commit/9a07647ee120da5b046cc71186590decebc8ded9 |