Bug 172559

Summary:	Initial layout for the panel in RTL desktops is borked
Product:	[Unmaintained] plasma4	Reporter:	Diego Iastrubni <elcuco>
Component:	general	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED NOT A BUG
Severity:	normal	CC:	aseigo
Priority:	NOR	Keywords:	rtl
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Unspecified
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Diego Iastrubni 2008-10-11 01:21:44 UTC

Version:            (using Devel)
Installed from:    Compiled sources

When running in RTL mode, the order of the plasmoids in the panel container should be reversed: the menu should be on the right, and the clock on the left.

In theory, QGraphicsLinearLayout should handle this automagically for us, but this is not ready for Qt4.4. So, my suggestion is that we ship another layout for RTL desktops and use that special one for the 4.2 release: this layout will be ordered visually (not logically), and will be applied for new desktops (like we did in KDe 3.2).

This is a workaround until QGraphicsLinearLayout gets fixed, or we write a new linear layout class. 

BTW, the desktop should be mirrored as well... but that's another bug ;-)

Comment 1 Aaron J. Seigo 2008-10-18 22:22:26 UTC

*** Bug 172558 has been marked as a duplicate of this bug. ***

Comment 2 Aaron J. Seigo 2008-10-18 22:25:20 UTC

as you note, this is a bug in Qt. working around it by rewriting our own layouts would only fix the panel and nothing else (inc apps outside of plasma that use QGraphicsView), cause us to spend a lot of time doing so and then probably revert once Qt is fixed. *Qt* needs to be fixed, not plasma.

this is an upstream bug...

Comment 3 Diego Iastrubni 2008-10-18 22:57:48 UTC

I was not able to explain my self correctly, sorry.

I do not want to write a new QGraphicsLinearLayout, but I suggested to ship by default 2 default desktop configurations: one for LTR and one for RTL.

Comment 4 Aaron J. Seigo 2008-10-18 23:02:03 UTC

.. which would then break as soon as Qt gets fixed, because the items would then get reversed (and be in an apparent "LTR" order) due to the layout doing the switch.

Comment 5 Diego Iastrubni 2008-10-18 23:29:10 UTC

I am totally aware of this, I still remember how it failed on KDE 3.2 :)

But, IMHO, for the first version of plasma that works on the new and fixed QGC layout system, we can make a little piece of code that fixes our hack...

on the other had, why not doing this hack right now? when running in RTL mode, just push the items in reverse order, this way the hack stays local to the 4.2 release (also saving should be done in reverse mode).

This is the first version of the 4.X family to be released with hebrew support (we had Hebrew since 1.1.4, all 2.x and all 3.x). I would like to go an extra mile and get the best first impression for the 4.X family for our users.