Summary: | kdevelop crash on click @ project root multiple times | ||
---|---|---|---|
Product: | [Unmaintained] kdelibs | Reporter: | christian <ch75> |
Component: | kdecore | Assignee: | Evgeniy Ivanov <pfx.kde> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | apaku, pfx.kde |
Priority: | NOR | ||
Version: | SVN | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
christian
2008-10-07 02:17:42 UTC
a quick workaround is to remove the git/bazaar/mercurial .desktop files. Apparently our dvcs plugins still have some serious stability problems. I can reproduce the bug. And also we had such problem during SoC, but decided it's a BIC problem. I will write some tests for dvcsJob during this week. It seems to me, that DVCSjob is called too fast: first is deleted when the second is used. Maybe they get the same address (not sure it can be). Maybe it destructed twice in some way... Andreas, please assign the bug to me (I don't have permissions yet). Hear is the main problem: http://api.kde.org/4.x-api/kdelibs-apidocs/kdecore/html/kjob_8cpp-source.html#l00186 Sometimes signal are generated before loop.exec(). So if we have deleteLater we will crash (or have a deadLock with no deleteLater). Am I right? I will fix it tomorrow (also found few glitches in DVCSjon) and commit. could you please explain in more depth what exactly the cause is and why. Feel free to do that on the mailinglist as that allows for easier discussion... re-assigning the bugreport to kdelibs as the problem really is in KJob. I've sent a patch for review and am waiting for approval. SVN commit 872341 by apaku: Do not start the event loop when emitResult was called from inside start() (i.e. the job cannot start because there's an error). Starting the eventloop caused crashes or deadlocks, depending on wether the job deleted itself or not. BUG: 172309 M +6 -2 kjob.cpp M +2 -0 kjob_p.h WebSVN link: http://websvn.kde.org/?view=rev&revision=872341 |