Summary: | Crash fetching data from GCALDaemon (google calendar proxy) | ||
---|---|---|---|
Product: | [Applications] korganizer | Reporter: | Frédéric MEUROU <frederic> |
Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | kevin.kofler, smartins, tuju |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Frédéric MEUROU
2008-09-25 15:20:23 UTC
Same faulty line, different triggering conditions: https://bugs.kde.org/show_bug.cgi?id=171787 Possibly the same bug in kdepim 3.5.10: https://bugzilla.redhat.com/show_bug.cgi?id=465211 The offending line: > if ( mIncidence->type() == "Todo" > && !KOPrefs::instance()->todosUseCategoryColors() ) { There's a check earlier in that function: if ( !mIncidence ) { return; } and the KDE 3 version had this comment for it: //HACK // to reproduce a crash: // 1. start Kontact with the Calendar as the initial module // 2. immediately select the summary (which must include appt and to-do) // causes a crash for me every time in this method unless we make // the following check if ( !mIncidence )return; but apparently mIncidence can't just be NULL, it can also be an invalid pointer. :-( yes, very similar to 171787. Frédéric, does this happen 100% of the time you add a GCALDaemon account? I think this isn't related to GCalDaemon, just a coincidence. GCalDaemon accounts work fine here. SVN commit 924015 by smartins: requestClose() must be called before save() because save() causes resourceClosed() to be called. Currently, the first time a resource is closed it doesn't really get closed but it stays marked to be closed (because of requestClose()), then, when a normal save comes, like when you add an incidence, closeResource() will close the resource because there's a pending close request, all incidences are freed and you get a KOAgendaItem::paintEvent() crash. CCBUG: 171651 CCBUG: 171787 M +3 -1 resourceview.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=924015 I reproduced the crash and fixed it, but there are so many paintEvent bug reports that I'm not sure which ones got fixed. The backtrace I got was very similar to 171651 and 171787 So can you retest? I see you're using compiled sources, the patch is in the websvn link above. Closing, the above commit fixed this problem for me. |