| Summary: | Clicking on systray icon does not show/hide the main window | ||
|---|---|---|---|
| Product: | [Applications] akregator | Reporter: | András Manţia <amantia> |
| Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alex.merry, droebuck, gekylafas, krishna.ggk, mattia.milleri, rasasi78, schwarzer, uwolfer, wrar, zeratul |
| Priority: | NOR | ||
| Version: | SVN | ||
| Target Milestone: | --- | ||
| Platform: | Unlisted Binaries | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Toggles the Akregator::Part visibility between hide and show when system tray icon is clicked.
Toggles the Akregator::Part visibility between hide and show when system tray icon is clicked. |
||
|
Description
András Manţia
2008-09-25 10:32:24 UTC
*** Bug 172039 has been marked as a duplicate of this bug. *** Created attachment 27761 [details]
Toggles the Akregator::Part visibility between hide and show when system tray icon is clicked.
This is my first ever patch to akregator, so please correct me if something is wrong.
This patch adds a new slot called slotToggleVisibility to MainWindow and is invoked on signal toggleShowPart from Akregator::Part.
Note: showPart is refactored to toggleShowPart everywhere to reflect this change.
Created attachment 27764 [details]
Toggles the Akregator::Part visibility between hide and show when system tray icon is clicked.
Also renamed TrayIcon showPart signal as toggleShowPart.
This patch is btw, wrt to the trunk (revision #869633)
Added me to cc list (sorry for 3 separate mails) Patch looks good to me. SVN commit 870288 by uwolfer: Fix: Clicking on systray icon does not show/hide the main window. Patch by Gopala Krishna A. (Not needed to backport to 4.1, as it is not broken there IIRC.) BUG:171642 M +1 -1 akregator_part.cpp M +1 -1 akregator_part.h M +7 -2 mainwindow.cpp M +1 -0 mainwindow.h M +2 -2 trayicon.cpp M +1 -1 trayicon.h It IS broken in 4.1.2 because of r864309 I do not feel comfortable to backport, because the patch does not cleanly apply to 4.1 branch and I cannot try build. Alex: you have committed r864309 which broke things according to comment above. Could you please check? winterz backported my fix (r860909) from trunk (which was really only half a fix - it makes the tray icon show the window, but not hide it, and this is what Gopala Krishna A changed). So I can't really comment on what it does to the branch, other than that it will probably prevent Akregator from being hidden by clicking the tray icon if it worked before. Akregator from 4.1.2 shows the window when clicking, but doesn't hide it. I thought this bug is entirely about this behavior. It's not obvious from the title, and the report is no help (hint to submitter: please include "what it does" and "what you expect it to do" in the report). If it worked properly before r864309, it should be reverted. If not, r870288 (ie: the patch attached to this bug) should be backported. I don't have any way of testing which scenario is true. There is relevant report in Kubuntu about the branch bug: https://bugs.launchpad.net/ubuntu/+source/kdepim/+bug/276880 SVN commit 874882 by uwolfer: Revert r864309, which was not necessary to backport (breaks things as confirmed multiple times; please retest now) CCBUG:171642 M +0 -2 mainwindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=874882 Verified for 4.1.3. I'm using 4.1.3, clicking on the icon still doesn't show or hide, but I can right click and I can fetch, configure or quit. I read that it's fixed for kubuntu (https://bugs.launchpad.net/ubuntu/+source/kdepim/+bug/276880), but I'm currently using opensuse. Also seen in Debian http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=513323 KDE Version 1.4.2 (KDE 4.2.2 (KDE 4.2.2), Kubuntu packages) Application KDE feed aggregator Operating System Linux (i686) release 2.6.28-11-generic Compiler cc I can still report this happening with the new Kubuntu 9.04 release. |