Summary: | Presentation effect crashes Kwin | ||
---|---|---|---|
Product: | [Plasma] kwin | Reporter: | Rosetzky Cedric <loacoon> |
Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Rosetzky Cedric
2008-09-24 15:52:20 UTC
Should be fixed in r863746 It's happening in revision 864316. SVN commit 864365 by lmurray: Prevent present windows from storing data for a NULL window. CCBUG: 171593 M +8 -5 presentwindows.cpp --- trunk/KDE/kdebase/workspace/kwin/effects/presentwindows.cpp #864364:864365 @@ -255,13 +255,13 @@ if( m_highlightedWindow == w ) setHighlightedWindow( findFirstWindow() ); m_windowData[w].visible = false; // TODO: Fix this so they do actually fade out - m_motionManager.unmanage( w ); rearrangeWindows(); } void PresentWindowsEffect::windowDeleted( EffectWindow *w ) { m_windowData.remove( w ); + m_motionManager.unmanage( w ); } bool PresentWindowsEffect::borderActivated( ElectricBorder border ) @@ -456,12 +456,17 @@ } if( windowlist.isEmpty() ) { - setHighlightedWindow( NULL ); + setHighlightedWindow( NULL ); // TODO: Having a NULL highlighted window isn't really safe return; } // We filtered out the highlighted window - if( m_windowData[m_highlightedWindow].visible == false ) + if( m_highlightedWindow ) + { + if( m_windowData[m_highlightedWindow].visible == false ) + setHighlightedWindow( findFirstWindow() ); + } + else setHighlightedWindow( findFirstWindow() ); int screens = m_tabBoxEnabled ? 1 : effects->numScreens(); @@ -949,10 +954,8 @@ QVector< bool > taken; taken.fill( false, columns * rows ); foreach( EffectWindow* w, windowlist ) - { if( m_windowData[w].slot != -1 ) taken[ m_windowData[w].slot ] = true; - } int slotWidth = area.width() / columns; int slotHeight = area.height() / rows; if( m_tabBoxEnabled ) Did the above commit fix the crash? I still need to update, I'll do it ASAP, let you know if it fixes the crash. It works now, the bug is fixed ;). Thank you. |