Bug 170660

Summary:	Completing recurring to-do doesn't create new to-do
Product:	[Applications] korganizer	Reporter:	gjditchfield
Component:	todoview	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	1, bhole, christophe, clara.gnos, jakob.kummerow, smartins
Priority:	NOR	Keywords:	triaged
Version First Reported In:	4.1.2
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Patch for recurring to-do issue.

Description gjditchfield 2008-09-08 05:16:22 UTC

Version:           4.1.0 (using 4.1.1 (KDE 4.1.1), Kubuntu packages)
Compiler:          cc
OS:                Linux (i686) release 2.6.27-2-generic

I booted a Dell D600 from a Kubuntu Intrepid alpha 5 CD and launched Kontack.  I went to the Calendar view and deleted the first of two "Default Korganizer resource" entries (which is a different, Intrepid bug).

I went to the To-do List and created a new recurring to-do:
- title "comptest"
- start date 2008-09-13
- end date 2008-09-13
- checked off "Enable Recurrence"
- selected recurrency type Monthly
- all other fields left at their default values.
I clicked OK.  The to-do list displayed the new  comptest to-do with an unchecked check box, recurs: yes, complete: 0%, and due date/time 2008-09-13, just as I expected.

I checked off the check box.  "Complete" changed to 100%, and the due date remained 2008-09-13.  No new to-do appeared in the list.  I was expecting a new to-do with an unchecked checkbox, 0% complete, and a due date of 2008-10-13, which is what the KOrganizer in KDE 3.5 does.

When I right-click comptest and select "Show", the Event Viewer window that pops up says "This is a recurring to-do. The next occurrence will be on 00:00".  No date is given.

I changed the summary view settings to show to-dos due within the next 60 days, but the summary view does not show a to-do due 2008-10-13.

There is nothing to show that a to-do is due in October.

Comment 1 Ben P. 2008-09-18 01:40:44 UTC

I get this too, and is one reason I switched from Sunbird back to Korganizer.  I usually put my bills as recurring to-dos.  When I pay one, I click completed, but the next instance of the bill is not created - I have to manually re-create it myself. (I seem to remember korganizer doing it correctly with previous versions, maybe even 4.1.0)

Comment 2 Pete 2008-10-31 14:10:23 UTC

I see this problem too.  I'm running KOrganizer version 4.1.0 using KDE 4.1.2 on Ubuntu Intrepid.

This seems to be a regression since 3.5.9 in Ubuntu Hardy.  Recurring todo items always worked correctly for me in that version.

Comment 3 Christophe Marin 2008-11-08 15:09:24 UTC

*** Bug 173619 has been marked as a duplicate of this bug. ***

Comment 4 Christophe Marin 2008-11-08 15:37:27 UTC

Confirmed with 4.1.72.

Comment 5 Clara Gnos 2009-01-14 19:34:30 UTC

Have the same problem with 4.1.96

This makes todos nearly useless for me (I have to manage periodical events most of the time)

Comment 6 Pete 2009-01-15 00:33:30 UTC

Incidentally, the workaround described in bug 173619 doesn't work for me.  If I add a time to the to-do, it usually works for one or two recurrences.  Eventually, however, the to-do is simply marked completed and no new occurrences are scheduled.

Comment 7 Pete 2009-02-26 21:44:57 UTC

I finally got fed up with this problem today, so I went and investigated it. :-)

It looks as though there is a test, which ensures that to-dos are not rescheduled if the "end on" date has been reached.  If no "end on" date has been set, this test seems to give the wrong answer.  It should say that the "end on" date has not been reached, because no such date has been set, but actually it says that the date has been reached and so the to-do is not rescheduled.

I will upload a patch, which is against KDE 4.2.0.  If someone could review it, I would be very grateful.  Bear in mind that I'm not familiar with this code, so although the patch works for me, it's possible that I've done something silly!

Comment 8 Pete 2009-02-26 21:46:05 UTC

Created attachment 31658 [details]
Patch for recurring to-do issue.

Comment 9 Sergio Martins 2009-02-26 22:00:55 UTC

I'm glad you made a patch, I was thinking of fixing it when it reached 65 votes ;)

Post it here: http://reviewboard.kde.org/ (choose KDEPIM as the group) or I'll post it for you tomorrow.


Thanks!

Comment 10 Sergio Martins 2009-02-27 00:09:55 UTC

I might be missing something but I can't reproduce this bug with KDE trunk. Only 4.2/4.2.1

Comment 11 Sergio Martins 2009-02-27 00:55:18 UTC

Ah, the to-do must have a due date before today for the bug to appear. I'll post the patch right now.

Comment 12 Pete 2009-02-27 11:24:34 UTC

65 votes?  One more sockpuppet would have done it, then. :-)

Do you still need me to post the patch on reviewboard, or are you saying you've already done that?

Thanks for your help getting this patch looked at, by the way.

Comment 13 Sergio Martins 2009-02-27 16:09:18 UTC

SVN commit 932890 by smartins:

endDateTime is invalid if the recurrence doesn't have an end.

Thanks to Pete for his patch.

Review board link: http://reviewboard.kde.org/r/197
BUG: 170660


 M  +3 -1      todo.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=932890

Comment 14 Sergio Martins 2009-02-27 16:21:16 UTC

I think you'll have to wait for KDE-4.2.2 as 4.2.1 was tagged earlier today.