Bug 170496

Summary: kget repeats old downloads on startup
Product: [Applications] kget Reporter: Fred Wells <fredcwells>
Component: generalAssignee: KGet authors <kget>
Status: RESOLVED FIXED    
Severity: normal CC: 4ernov, loacoon, sebastian.radish, shiningyu
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Fred Wells 2008-09-06 01:20:57 UTC
Version:            (using KDE 4.1.0)
OS:                Linux
Installed from:    Fedora RPMs

After successfully downloading files with "unknown" size, kget downloads them again on subsequent operations.  This repeats each time kget runs unless the files are removed from the list.
Comment 1 Urs Wolfer 2008-09-06 15:29:58 UTC
Does this also happen if such a download has been finished before you quit KGet?
Comment 2 Ningyu Shi 2008-09-06 17:22:21 UTC
well, afaik (boom1992 told me), this is a known bug. kget doesn't save the info about transfer state now. So every time kget starts up, it just restart everything, and it's up to the transfer-plugin to determine whether to start it again. When this comes to KIO, it will query the size of the download and see if there is a file with same size in the directory. So if there is no size info from the server, it always restarts it. This can be fixed by saving transfer state in the list.
Comment 3 Lukas Appelhans 2008-09-06 18:14:12 UTC
Yes, this is true :) It's pretty easy to fix, just save the state of the Transfer :)

Lukas
Comment 4 Fred Wells 2008-09-07 00:01:14 UTC
Yes, it does restart previous downloads that have successfully completed.   It would also be nice to add the option to cleanup all successful downloads on exit.  As it is, the user must manually cleanup.  Ugly.
Comment 5 Lukas Appelhans 2008-12-16 21:03:32 UTC
Can you test if this Bugreport is still valid?

Lukas
Comment 6 Fred Wells 2008-12-17 03:37:00 UTC
Yes, still exists in KGet 2.1.3 (KDE 4.1.3).

Steps to reproduce.

1. Download any of the images from this site:

http://www.wallpaperweb.org/wallpaper/space/gallery_1.htm

2. Note the filesize in KGet is 'n/a'.

3. Delete the downloaded image.

4. Download a different image.

5. New image will be downloaded as well as the original (again).
Comment 7 Lukas Appelhans 2008-12-17 13:06:54 UTC
Well for me it does not show filesize == n/a, I tried 2 image and both had a file-size...

Lukas
Comment 8 Fred Wells 2009-05-20 05:25:35 UTC
Problem still present in 4.2.3.
Comment 9 Carsten Pfeiffer 2009-07-23 11:55:55 UTC
SVN commit 1001434 by pfeiffer:

BUG: 170496
CCMAIL: kget@kde.org
do not save finished transfers in the transfers.kgt list at all


 M  +8 -4      transfergroup.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1001434
Comment 10 Carsten Pfeiffer 2009-07-23 11:56:40 UTC
SVN commit 1001436 by pfeiffer:

BUG: 170496
forward port from 4.3 branch: do not save finished transfers in the transfers.kgt file at all


 M  +6 -2      transfergroup.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1001436
Comment 11 Carsten Pfeiffer 2009-07-23 12:02:11 UTC
*** Bug 201146 has been marked as a duplicate of this bug. ***
Comment 12 Carsten Pfeiffer 2009-07-23 12:03:32 UTC
*** Bug 185155 has been marked as a duplicate of this bug. ***
Comment 13 Rosetzky Cedric 2009-08-28 03:04:15 UTC
Looks like this bug has just been reintroduced in trunk...
Comment 14 Lukas Appelhans 2009-08-28 12:32:18 UTC
Yeap, let's mark it as that...

Lukas
Comment 15 Matthias Fuchs 2009-09-11 19:10:54 UTC
SVN commit 1022402 by mfuchs:

Downloads with KIO that were downloaded elsewhere (e.g. Konqueror) do not restart anymore.
BUG:170496

 M  +24 -3     transferKio.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1022402
Comment 16 Matthias Fuchs 2009-09-11 19:50:38 UTC
SVN commit 1022408 by mfuchs:

Backport r1022402
Downloads with KIO that were downloaded elsewhere (e.g. Konqueror) do not restart anymore.
CCBUG:170496


 M  +23 -0     transferKio.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1022408