Bug 170031

Summary: scoring dialog: conditions are sometimes lost, actions always lost
Product: [Unmaintained] knode Reporter: Maciej Pilichowski <bluedzins>
Component: generalAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: nive
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Unspecified   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Maciej Pilichowski 2008-08-29 13:57:55 UTC
Version:            (using KDE 4.1.0)

scoring dialog: conditions are sometimes lost, actions always lost

Well, for conditions for example you edit them, you add new rule, the conditions from previous rule (the ones you edited second ago) are gone.

For actions it is impossible to define anything, because no matter what I do -- apply, ok, new rule, more (actions) the defined action is deleted.
Comment 1 Olivier Trichet 2008-11-10 22:15:20 UTC
same issue as bug #170030
Comment 2 Maciej Pilichowski 2008-11-10 22:21:31 UTC
Not at all.

Simplest proof -- fixing one issue has no impact on another. End of proof.
Comment 3 Olivier Trichet 2008-11-10 22:31:00 UTC
This is definitly the same issue. See the patch in #170030 which fix both.

Simplest proof -- fixing one issue has immediate impact on another. End of proof.
Comment 4 Maciej Pilichowski 2008-11-10 22:43:07 UTC
:-) 

Just in case, one issue
data change -> accept changes -> changes rejected

second issue
data change -> exit -> confirm exit

If the patch really fixed those two issues, then ok, let's close the reports.
Comment 5 Olivier Trichet 2008-11-11 00:43:32 UTC
Yes this fix those issues because the Apply, OK and cancel buttons work as expected and actually save (or not) the rules. There is no need to confirm exit.
Comment 6 Maciej Pilichowski 2008-11-11 08:21:49 UTC
And what happens when user clicks on [x] widget (in the titlebar -- it is close action)? No confirmation too? -- then the other report is still valid.
Comment 7 Olivier Trichet 2008-11-16 11:44:43 UTC
The standard meaning of the [X] button is "cancel", so there is no needed confirmation.
Therefore I close this bug as fixed