| Summary: | Text files preview does not support international symbols | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] kdelibs | Reporter: | Ben Aceler <aceler> |
| Component: | general | Assignee: | kdelibs bugs <kdelibs-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andresbajotierra, peterkur |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | Screenshot | ||
|
Description
Ben Aceler
2008-08-18 18:01:35 UTC
Created attachment 28248 [details]
Screenshot
non-ascii characters does not shown in the thumbnail
Confirmed for Dolphin 1.1 in KDE 4.1.2 This is because the textthumbnail generator uses an ascii chart for the character fonts instead real fonts. However, text files containing non-ascii chars are not currently considered plain text files and therefore their preview aren't generated. SVN commit 990397 by cfeck: Let Qt render text thumbnails We used a tiny bitmapped font which was unfortunately lacking any non ASCII characters. We now detect non ASCII files as text files, so we should render them better. This code uses the smallest readable font, but currently forces it to a very small pixel size (similar to what the old code used). The text encoding detection might need some improvements, e.g. use the default locale encoding, when the prober is not very sure. Reviewed by Peter Penz Reviewed by Darío Andrés See http://reviewboard.kde.org/r/760/ BUG: 169381 CCBUG: 188355 M +0 -1 CMakeLists.txt M +39 -112 textcreator.cpp M +0 -3 textcreator.h D thumbnailfont_7x4.png WebSVN link: http://websvn.kde.org/?view=rev&revision=990397 |