Bug 169272

Summary: alerts.xml is poorly ordered, insufficient, and contains a bug.
Product: [Applications] kate Reporter: Greg Metcalfe <metcalfegreg>
Component: syntaxAssignee: KWrite Developers <kwrite-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: dhaumann
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Fedora RPMs   
OS: Linux   
Latest Commit: Version Fixed In:

Description Greg Metcalfe 2008-08-16 23:10:42 UTC
Version:           2.5.9 (using KDE 3.5.9)
Installed from:    Fedora RPMs
Compiler:          gcc (GCC) 4.1.2 20070925 (Red Hat 4.1.2-33)
 
OS:                Linux

Existing:
<language version="1.06" kateversion="2.3" name="Alerts" section="Other" extensions="" mimetype="" author="Dominik Haumann (dhdev@gmx.de)" license="LGPL" hidden="true">
  <highlighting>
    <list name="alerts">
      <item> FIXME </item>
      <item> HACK </item>
      <item> NOTE </item>
      <item> TODO </item>
      <item> NOTICE </item>
      <item> TASK </item>
      <item> ### </item>

Note that '###' does not highlight, and I'm not sure that it ever has in any KDE 2 or 3. That's the bug.

My argument for insuffiency is that there aren't enough tags for both highlighting, and reasonable 'grep' targets for code-sweeping tools. I'd like to see something like the following, if all you can do is a reorder:

      <item> FIXME </item>
      <item> TODO </item>
      <item> TASK </item>
      <item> HACK </item>
      <item> NOTE </item>
      <item> NOTICE </item>
      <item> ### </item>

But it's ironic that we'd still have an alerts.xml which doesn't handle ALERT, and would still contain the '### does not highlight' bug.

I propose:
      <item> FIXME </item>
      <item> TODO </item>
      <item> TASK </item>
      <item> TEST </item>
      <item> TESTING </item>
      <item> HACK </item>
      <item> BUG </item>
      <item> NOTE </item>
      <item> NOTICE </item>
      <item> ALERT </item>
      <item> WARNING </item>
      <item> DANGER </item>
      <item> SECURITY </item>
      <item> TEST </item>
      <item> TESTING </item>
      <item> ### </item>

'###' should be fixed or removed.
Comment 1 Greg Metcalfe 2008-08-17 05:02:48 UTC
I accidentally duped:
    <item> TEST </item> 
    <item> TESTING </item>
at the end. Those should appear as they do toward the top of the proposal, as 
the 4th and 5th entries.
Comment 2 Dominik Haumann 2008-08-19 00:39:58 UTC
fixed in r849052 for KDE 4.2