Bug 169227

Summary: Configure shortcuts dialog broken
Product: [Applications] digikam Reporter: Gandalf Lechner <gandalflechner>
Component: Usability-KeyboardAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: 0.10.0   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In: 0.10.0
Sentry Crash Report:

Description Gandalf Lechner 2008-08-16 12:26:37 UTC 
Version:           0.10.0-beta3 (rev.: 847754) (using 4.1.00 (KDE 4.1.0), Kubuntu packages)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.24-17-generic

1) The configure shortcuts dialog of the album view behaves in a strange manner: When changing the color scheme of digikam, opening this dialog will sometimes only show the kipi-plugin for exporting a gallery as the only item in the list. Opening the configure shortcuts dialog two or three times usually brings up the full list. 

2) Also when the full list is visible, the export gallery action can be found at the very top of the list, on the same level as the "general" item.

3) The first entry in the list of general actions is empty.

4) Moreover, in some dark color themes the list in this dialog is hardly readable since the text of the items with a light background is not dark enough to provide sufficient contrast.


The configure shortcuts dialog of the image editor works better, i.e. 1) and 2) are absent here. But 3) and 4) also apply to this dialog.
Comment 1 Andi Clemens 2008-08-16 12:37:37 UTC 
Since the shortcut config dialog is a KDE dialog and has nothing to do with digiKam at all, I think this bugreport is invalid for digiKam.
And I can't confirm point 1) and 2) either.

Point 3) you mentioned is correct, there must exist an action with an empty name, I'll investigate this.

Point 4) is a theming issue that seems only to be seen in some Qt styles, so maybe this also is not relevant of digiKam.

Andi
Comment 2 Gandalf Lechner 2008-08-16 12:40:22 UTC 
If it was a KDE bug, shouldn't the configure shortcuts dialog of the image editor be broken, too?
Comment 3 Andi Clemens 2008-08-16 12:45:58 UTC 
As I said before, I can not confirm your first two points. Maybe we will have to wait for other users confirming this one.

We do not create this dialog, so we can't do a lot about this. If the dialog behaves strange there is a possibility that a lot of KDE4 applications suffer this problem. But again right now this is not reproducible here and so I can not make any further investigations (so right now it is not our fault :-))

For point 3): I have assigned a keyboard shortcut for the empty action, nothing happens. So there is either an action running with no visible output (no dialog, no status bar indicator etc) or this action just doesn't exist at all (but then I don't know what it is doing there).

I think we need more input from other users / devs.

Andi
Comment 4 Michael Jansen 2008-10-28 02:34:42 UTC 
The action without text is the logo_action.
Comment 5 caulier.gilles 2008-12-22 09:47:17 UTC 
Andi,

Is this file can be considerated solved now since we have fixed kipi-plugins keyboard shorcuts registration in configure dialog ?

Gilles
Comment 6 Andi Clemens 2008-12-22 10:01:24 UTC 
Oh sure... Closing...
Comment 7 Andi Clemens 2008-12-22 10:05:29 UTC 
Point 3 for the logo_action is still valid, maybe we should give it a descriptive text or remove it from actionsCollection()
Comment 8 caulier.gilles 2008-12-22 11:24:47 UTC 
Fixed with commit #900124.

Gilles