| Summary: | Dolphin crashes at startup: ASSERT: "(*it).isValid()" in file previewjob.cpp | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Carsten Schlipf <carsten.schlipf> |
| Component: | general | Assignee: | Peter Penz <peter.penz19> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | andresbajotierra, artusek, bugs.kde.org, frank78ac, holgerix, johan.hake, lodp, Mike_Achtelik, pedromorgan, radmen, xkrez |
| Priority: | NOR | ||
| Version: | 16.12.2 | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
dolphinrc file that causes the crash
A dolfinrc causing my dolphin to crash Patch to fix the problem |
||
|
Description
Carsten Schlipf
2008-08-14 09:38:27 UTC
This may be related/duplicate of bug 168008 I created a new user and started dolphin as that user. This time it worked. So it seems to be related to some configuration files in my ~/.kde4 directory. Thanks Carsten for the update. I could not reproduce this issue here, hopefully it really was just a problem due to an old installation... Is it OK to set this issue to WORKSFORME? There are so many open issues that I must take care closing all the issues which are not reproducible ASAP. Otherwise please just reopen this issue again and I'll have to reassign this to kdelibs... Hi Peter, on my real user account it still does not work. But I see your point. When I have some time I will try to pin down the configuration file that causes the problem and possibily attach this file so that you may be able to reproduce this. Then I will reopen it. Until then I leave it as RESOLVED WORKSFORME - at least there is one workaround available. Thank you very much for your great work! Created attachment 26863 [details]
dolphinrc file that causes the crash
When this file was stored as ~/.kde4/share/config/dolphinrc, dolphin crashed at
startup
OK... just remembered that there are additional configuration files in ~/.kde4/share/config and the old dolphinrc file was indeed the cause for this crash. Please find the file attached in comment #5. I am reopening this bug report therefore. Thanks Carsten, the dolphinrc that causes the crash is very useful. I've added this to my TODO-list... Created attachment 27083 [details]
A dolfinrc causing my dolphin to crash
I can confirm this bug. The part of my dolphinrc file that is similare to Carstens file is the topmost part, which is not included in a section header. That to say: ---------------------------- Height 1200=663 State= (Truncated long line) Width 1600=1010 ---------------------------- When I removed this part from my dolphinrc file it worked again. I have also added my dolfinrc file below. Johan *** Bug 168008 has been marked as a duplicate of this bug. *** *** Bug 169923 has been marked as a duplicate of this bug. *** Note that the duplicate bug 169923 gives instructions how to get the configuration into the broken state: "When you move both panels out of the main window, quit dolphin and then re-open it, you get a crash." *** Bug 172161 has been marked as a duplicate of this bug. *** *** Bug 172723 has been marked as a duplicate of this bug. *** Created attachment 27886 [details]
Patch to fix the problem
I've looked a bit into this. The problem appears to be in DolphinMainWindow::init(): This function calls setupGUI() before the signal urlChanged(homeUrl) is emitted, and in the case that the Information Panel is detached from the main window, this means that InfoSidebarPage::showItemInfo() is called before its URL is set. That function calls KIO::filePreview() which checks if the URL it gets is valid with an assert.
Moving "emit urlChanged(homeUrl);" from the end of DolphinMainWindow::init() solves the problem for me. It must be called after setupDockWidgets() because the signals and slots get connected there, but before setupGUI() in order to prevent the crash. I can't see any bad side effects of this, but I'm not really familiar with the code ;-)
I've verified that I get no crashes with the dolphinrc attached to this report and the one from the dup 172723 (Dolphin indeed opens with a detached Information panel with these).
*** Bug 171610 has been marked as a duplicate of this bug. *** SVN commit 871525 by ppenz: Assure that the docks get informed about an URL change before the GUI is setup (thanks to Frank Reininghaus for the patch!). This prevents that slots from the docks are called with invalid URLs. BUG: 169103 CCMAIL: frankreininghaus@web.de> M +1 -1 dolphinmainwindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=871525 SVN commit 871529 by ppenz: Backport of SVN commit 71525: Assure that the docks get informed about an URL change before the GUI is setup (thanks to Frank Reininghaus for the patch!). This prevents that slots from the docks are called with invalid URLs. CCBUG: 169103 CCMAIL: frankreininghaus@web.de M +2 -3 dolphinmainwindow.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=871529 *** Bug 173190 has been marked as a duplicate of this bug. *** Thanks to comment #6 deleting the ~/.kde4/share/config/dolphinrc file solved the problem *** Bug 174870 has been marked as a duplicate of this bug. *** *** Bug 175865 has been marked as a duplicate of this bug. *** |