Bug 168978

Summary:	chat window is raised across different desktops when message queue is off
Product:	[Unmaintained] kopete	Reporter:	Mihai RUSU <dizzy>
Component:	general	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	0.50.80
Target Milestone:	---
Platform:	Gentoo Packages
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:
Attachments:	Don't raise chat window

Description Mihai RUSU 2008-08-12 15:27:39 UTC

Version:           0.50.80 (using KDE 4.1.0)
Installed from:    Gentoo Packages
Compiler:          gcc (GCC) 4.1.2 (Gentoo 4.1.2 p1.1) 
OS:                Linux

Hello

In kde 3.5.9 (and all kde >= 3.3.x I remember using with kopete) I am using kopete as this:
- disabled message queue
- group all chat messages in the same window
- disabled: "Raise window on events"

With this configuration what I usually do is open up a chat window with someone say in desktop 1, then I switch to desktop 2/3... where I do my work and don't care. If I get messages (from the same user or from other users thus opening a new tab in the chat window) the window stays fine in desktop1 (or stays minimized there if I minimize it).

However, in kopete from kde 4.1 this is all changed. No matter in what desktop I am if I receive a message the window will be brought into the current desktop and raised. This is very annoying as it means when I call to a colleague to show him some work on desktop2, kopete might popup with some personal message from someone.

I would like to have the old behavior again. Thank you!

Comment 1 Roman Jarosz 2008-08-12 23:55:56 UTC

Created attachment 26814 [details]
Don't raise chat window

I didn't commit it because I'm not 100% sure about the change in
KopeteViewManager::slotEventDeleted. The KopeteView::raise is already called
when notify activated signal is emitted so I think that it should be ok if we
remove the activation from there.

Can anybody check if I'm right?

Comment 2 Roman Jarosz 2008-08-13 12:29:11 UTC

SVN commit 846257 by rjarosz:

Fix bug 168978 chat window is raised across different desktops when message queue is off

BUG: 168978



 M  +5 -2      kopeteviewmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=846257

Comment 3 Roman Jarosz 2008-08-13 12:33:23 UTC

Comment on attachment 26814 [details]
Don't raise chat window

Mihai if you want to test it please use the patch from "WebSVN link" because
the committed patch is different then the one that is attached here.

Comment 4 Roman Jarosz 2008-08-13 12:33:27 UTC

Comment on attachment 26814 [details]
Don't raise chat window

Mihai if you want to test it please use the patch from "WebSVN link" because
the committed patch is different then the one that is attached here.

Comment 5 Mihai RUSU 2008-08-13 12:36:49 UTC

Thanks for the warning, I was going to test it right now and was going to use the attached patch but I got your message in time. I think I will just wait for kde anonymous trunk to update (I think there was a delay there) and just compile trunk kopete. Will let you know how it works.

Comment 6 Mihai RUSU 2008-08-13 12:52:31 UTC

Seems to work fine (tested kopete trunk), thanks for your work. If there is/will be a KDE 4.1.x branch for bug fixes maybe you would consider porting it there too, thanks!

Comment 7 Roman Jarosz 2008-08-13 13:21:17 UTC

I will backport it to KDE 4.1, but want to wait a little bit and see if it will not cause any regressions.