Bug 168769

Summary:	In search mode, switching tabs always reset the scrollback location of the tab where I'm searching
Product:	[Applications] konsole	Reporter:	Ismael Barros <razielmine>
Component:	history	Assignee:	Konsole Developer <konsole-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	adaptee, andresbajotierra, ivan, jospoortvliet, jseakle, linds.r, robertknight
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:	http://commits.kde.org/konsole/cc7af6655625242a4dda2ed5c4c24d26b37f88ea	Version Fixed In:	4.9.0
Sentry Crash Report:

Description Ismael Barros 2008-08-08 19:51:23 UTC

Version:           2.1 (using 4.1.1 (KDE 4.1.0 (4.1 >= 20080722)), Arch Linux)
Compiler:          gcc
OS:                Linux (i686) release 2.6.25-ARCH

Current behaviour: If I activate the search mode and look for a keywords, konsole will autimatically place the scrollback position in the first match. If I start scrolling through the matching lines and swhitch to another tab, when getting back to the tab where I was searching the scrollback will be set again to show the first match.

Desired behaviour: konsole remembers my position in the scrollback and doesn't reset it, like when I'm not in search mode.

Comment 1 Dario Andres 2008-08-09 19:50:35 UTC

Version 2.1 Using KDE 4.1.1 (KDE 4.1.0 (4.1 >= 20080722)) (KDEmod) in ArchLinux i686:
I can reproduce this behaviour

Comment 2 Kurt Hindenburg 2008-08-10 21:45:38 UTC

Confirmed; it looks like when switching back to searched tab, Konsole always starts at the top of the scrollback history.

Comment 3 Robert Knight 2008-09-22 04:21:20 UTC

*** Bug 170172 has been marked as a duplicate of this bug. ***

Comment 4 Kurt Hindenburg 2008-10-05 00:41:10 UTC

The issue here is that activeViewChanged unplugs the Controller which in turn disconnects the searchbar for the prev tab (perhaps in case the new active tab has a searchbar?).  So upon re-activation of a search tab, the search bar is rebuilt/connected.

Comment 5 Robert Knight 2008-10-05 12:20:57 UTC

Hi Kurt,

The problem is not re-connecting the scrollbar itself but that SessionController::setSearchBar() causes a new search to be initiated.  I have patches in progress here to fix this.

Comment 6 Kurt Hindenburg 2010-06-18 17:01:39 UTC

*** Bug 242026 has been marked as a duplicate of this bug. ***

Comment 7 Kurt Hindenburg 2011-03-19 16:09:00 UTC

*** Bug 268675 has been marked as a duplicate of this bug. ***

Comment 8 Jekyll Wu 2012-06-01 13:53:10 UTC

Git commit cc7af6655625242a4dda2ed5c4c24d26b37f88ea by Jekyll Wu.
Committed on 01/06/2012 at 15:15.
Pushed by jekyllwu into branch 'master'.

Do not reset previous searching after switching tab

Thanks to Lindsay Roberts<linds.r@gmail.com> for the research and patch
FIXED-IN: 4.9.0
REVIEW: 105121

M  +17   -11   src/SessionController.cpp
M  +1    -0    src/SessionController.h

http://commits.kde.org/konsole/cc7af6655625242a4dda2ed5c4c24d26b37f88ea