| Summary: | When a jpeg file is updated (e.g. rotated in gwenview) it's thumbnail will not update in dolphin | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Diederik van der Boor <vdboor> |
| Component: | general | Assignee: | Simon St James <kdedevel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | peter.penz19 |
| Priority: | NOR | ||
| Version: | 16.12.2 | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Patch for one half of this issue.
Updated patch for KFilePreviewGenerator |
||
|
Description
Diederik van der Boor
2008-08-07 21:59:06 UTC
It depends on the notification system. Currently this is not possible, but AFAIK there is some work ongoing to improve this in kdelibs. I've set this issue to NEW, as from a users point of view I fully agree to your request. This will hopefully be half-fixed automatically when https://bugs.kde.org/show_bug.cgi?id=154676 I've submitted a preliminary patch to Flavio, but he is very busy at the moment so I'm not sure when (or if ;)) it will land in kdelibs. I've just tried a test case with my local, patched copy and the fact the picture was changed was picked up by Dolphin and the thumbnail was "refreshed". However, the refreshing didn't quite work and the old, stale thumbnail reappeared when the refresh was complete. I haven't yet investigated as to whether this is a problem with the kdelibs thumbnailing or Dolphin's IconManager. Either way, we'll have to be a bit careful to avoid continuous re-previewing when e.g. downloading a large file in a directory we've got open. Created attachment 26899 [details] Patch for one half of this issue. The attached patch won't work until there's a fix for https://bugs.kde.org/show_bug.cgi?id=154676 in SVN, but I've tried it locally with my kdirwatch patch and it seems OK. I'll attach it here so I don't lose track of it :) It's a little more complex than expected as I've pre-emptively fixed a bug that I noticed back when KDE3+Konqueror had this feature: downloading a video file into an open directory uses 100% CPU as the file is constantly changing and being re-previewed. This patch adds the file to the preview queue as soon as it detects the change, but won't preview it again until it has remained unchanged for a certain length of time. Created attachment 30016 [details]
Updated patch for KFilePreviewGenerator
Peter - could you please review to make sure this is eligible for kdelibs inclusion (especially with the Q_PRIVATE_SLOT stuff)? Thanks!
SVN commit 969368 by ppenz: Fixed issue that during a copy operation of huge files the preview will get regenerated constantly. Thanks to Simon St. James for the original patch. BUG: 168666 CCMAIL: kdedevel@etotheipiplusone.com M +68 -1 kfilepreviewgenerator.cpp M +1 -0 kfilepreviewgenerator.h WebSVN link: http://websvn.kde.org/?view=rev&revision=969368 @Simon: I've just committed a patch that is based on your patch. I've tested my patch against side effects in "normal" situations, but I could not verify the behavior when copying huge files (my video-plugin does not create any video preview...). I'm confident that the approach of the patch works, but I'd be glad that if you could do a check too. If there is an issue left, it should be only a minor detail... Thanks! Sure - will check this evening :) |