| Summary: | Rotating desktop/changing orientation doesn't work | ||
|---|---|---|---|
| Product: | [Unmaintained] kephal | Reporter: | arrenlex |
| Component: | General | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | notmart, stefnn |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
ksnapshot screenshot of desktop rotated using xrandr
Photograph of screen in xrandr-rotated state. ksnapshot after returning to normal orientation small patch that exchanges width<->height when rotated actually *use* the rotated newSize in the commited patch |
||
|
Description
arrenlex
2008-08-04 10:20:30 UTC
Created attachment 26620 [details]
ksnapshot screenshot of desktop rotated using xrandr
I rotated my screen over an ssh session, launched ksnapshot, then unrotated it
to make the window appear allowing me to save the file. Compare this to the
photograph of what's actually on the display (upcoming).
Created attachment 26621 [details]
Photograph of screen in xrandr-rotated state.
(brightened with the gimp for easier visibility). Note that this differs from
the ksnapshot screenshot in that a) the panel is 3/4 of the way down the
screen, not at the bottom like ksnapshot thinks it is, b) below the panel is
the kdm black background, not white or transparency or squares like ksnapshot
thinks it is.
Created attachment 26622 [details]
ksnapshot after returning to normal orientation
This is what happens every time I return to normal orientation. Note
a) bottom panel is back to the default Oxygen colour scheme, whereas normally I
have a glass theme on it (or maybe it's just the glass theme with a black
background? Hmm..)
b) The almost total lack of desktop except the strip at the top, but that's
hard to miss. :)
c) It's useable in this state... new windows will appear and move over the
black area just fine, it's not a void.
things have changed a bit after this report, since kephal is used now. however, on my laptop i can still reproduce it and is even worse, also the panel is on a too high position. it seems that Kephal::ScreenUtils::desktopGeometry() always return the not rotated geometry, i.e on that laptop always 1024x768 rather than 768x1024, so seems to be a problem in kephal *** This bug has been confirmed by popular vote. *** yes, as far as i tested it, kephal always returns the unrotated screen size. I am not quite sure at which point in the kephal design the rotation should be taken into account and change the screen size when rotated, but I made a patch (that works for me) against /libs/kephal/xrandr12/randrcrtc.cpp from kde 4.2 beta 2 (see attachment). Created attachment 29727 [details]
small patch that exchanges width<->height when rotated
stefnn: that patch works perfectly here! can it go in or can cause problems? SVN commit 905796 by aseigo: rotated? then rotate the geometry! based on a patch by stefnn BUG:168308 M +9 -1 randrcrtc.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=905796 Created attachment 29933 [details]
actually *use* the rotated newSize in the commited patch
Thanks for addressing this issue!
But right now the newSize is being calculated but not used. (see patch attached).
*bumping this as kephal still does not include the correct patch in kde-4.2.1 and trunk. SVN commit 999687 by cfeck: Actually use the rotated newSize Patch by stefnn BUG: 200600 CCBUG: 168308 M +2 -2 randrcrtc.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=999687 SVN commit 999689 by cfeck: Actually use the rotated newSize (backport r999687) CCBUG: 200600 CCBUG: 168308 M +2 -2 randrcrtc.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=999689 |